fix memory leak in find_label#71
Open
sorokin wants to merge 1 commit intonetwide-assembler:masterfrom
Open
Conversation
When running with -fsanitize=leak enabled nasm prints this error:
Direct leak of 504 byte(s) in 32 object(s) allocated from:
#0 0x7f7274bf9867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
netwide-assembler#1 0x55a15e7bbbc4 in nasm_malloc nasmlib/alloc.c:55
netwide-assembler#2 0x55a15e7bc069 in nasm_strcat nasmlib/alloc.c:139
netwide-assembler#3 0x55a15e7f3968 in find_label asm/labels.c:235
netwide-assembler#4 0x55a15e7f61f7 in define_label asm/labels.c:462
netwide-assembler#5 0x55a15e7ff1ce in parse_line asm/parser.c:665
netwide-assembler#6 0x55a15e7b75f8 in assemble_file asm/nasm.c:1735
netwide-assembler#7 0x55a15e7b04e4 in main asm/nasm.c:719
netwide-assembler#8 0x7f7274311d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
netwide-assembler#9 0x7f7274311e3f in __libc_start_main_impl ../csu/libc-start.c:392
netwide-assembler#10 0x55a15e7abe04 in _start (/home/ivan/d/nasm/nasm+0x2e2e04)
This error was reproducible on struc.asm test.
The problem was that not all exit paths freed the allocated
string.
Signed-off-by: Ivan Sorokin <vanyacpp@gmail.com>
Member
|
Is this still a problem? |
Contributor
Author
|
I tested the latest commit 22a9118 in master and, yes, the bug is still present. The steps to reproduce the problem are described in this comment: The problematic file is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running with
-fsanitize=leakenabled nasm prints this error:This error was reproducible on
struc.asmtest.The problem was that not all exit paths freed the allocated string.