fix memory leak in asm/nasm.c#31
Open
13579and2468 wants to merge 1 commit intonetwide-assembler:masterfrom
Open
fix memory leak in asm/nasm.c#3113579and2468 wants to merge 1 commit intonetwide-assembler:masterfrom
13579and2468 wants to merge 1 commit intonetwide-assembler:masterfrom
Conversation
cyrillos
requested changes
Sep 4, 2022
Contributor
cyrillos
left a comment
There was a problem hiding this comment.
Looks reasonable, but please make the proper changelog, see example here https://nasm.us/patches.php
Bug analysis: When the first argument of nasm is a pathname without '.', forget to free outname before set outname = "nasm.out";. bugzilla: https://bugzilla.nasm.us/show_bug.cgi?id=3392800 Signed-off-by: Szu-Wei Tseng <13579and24680@gmail.com>
0b96e35 to
05692ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compile it with asan
run
Analysis :
When the first argument of nasm is a pathname without '.', forget to free outname before set
outname = "nasm.out";.