feat: auto-expire OpenVPN sessions after configurable max age#8
Open
edospadoni wants to merge 3 commits intomasterfrom
Open
feat: auto-expire OpenVPN sessions after configurable max age#8edospadoni wants to merge 3 commits intomasterfrom
edospadoni wants to merge 3 commits intomasterfrom
Conversation
Add a background goroutine in ronzinante that periodically checks for expired VPN sessions and terminates them automatically. The cleaner runs every hour and on startup. For each expired session it connects to the OpenVPN management socket and sends a kill command. If the client is still connected, the existing disconnect hook handles cleanup. If the session is orphan (client not found on any socket), the cleaner creates a history entry and removes the session directly. New configuration fields (with defaults for backward compatibility): - openvpn_sockets: list of management socket paths - session_max_age: max session age in hours (default 24)
gsanchietti
reviewed
Mar 2, 2026
Co-authored-by: Giacomo Sanchietti <giacomo.sanchietti@nethesis.it>
Same fix applied to the disconnect hook endpoint: check if a history record already exists for the session before inserting a new one.
gsanchietti
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
killcommand to the OpenVPN management socket, letting the existing disconnect hook handle cleanupopenvpn_socketsandsession_max_age(default: 24h) with backward-compatible defaultsChanges
ronzinante/tasks/sessions.go— session cleaner goroutine with pure Go unix socket communicationronzinante/configuration/configuration.go— new config fields with defaultsronzinante/main.go— start cleaner after DB initdeploy/roles/windmill/templates/ronzinante.j2— add new fields to deploy templateReferences: