Remove stack trace printing to prevent information exposure#4
Open
Remove stack trace printing to prevent information exposure#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 1 security vulnerability identified by BoostSecurity.
Remove printStackTrace to prevent info exposure in
src/scala/com/twitter/recos/hose/common/RecosEdgeProcessor.scala(Line: 36)Risk:
Throwable.printStackTrace()wrote full stack traces to stderr, exposing internal class/method names, file paths, and potentially sensitive data (CWE-209).Fix: Removed
printStackTrace()fromRecosEdgeProcessorand replaced it with error metrics (including a per-exception-type counter) to retain observability without leaking implementation details.Review notes: Error handling behavior remains non-failing (
Future.Unit), but stack traces will no longer be emitted to stderr.Generated by BoostSecurity Advisor