Fix path traversal risk in ScorerModule temp file creation#10
Open
Fix path traversal risk in ScorerModule temp file creation#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 1 security vulnerability identified by BoostSecurity.
Prevent path traversal in ScorerModule temp file creation in
follow-recommendations-service/server/src/main/scala/com/twitter/follow_recommendations/modules/ScorerModule.scala(Line: 19)Risk:
fileFromResourcewrote to a temp file created with user-influenced input (resource) which could enable path traversal/unsafe path handling patterns when untrusted input controls file paths, potentially overwriting arbitrary files.Fix: Restricted
resourceto classpath entries under the expectedSTPScorerPathprefix, rejected..sequences, handled missing resources, and used a safe fixed temp file prefix/suffix (instead of usingresourceas part of the filename) while ensuring streams are closed.Review notes: Invalid or missing resources now throw
IllegalArgumentExceptioninstead of failing later.Generated by BoostSecurity Advisor