fix: pass api_versions in dispatch payload#95
Merged
Conversation
…ter for repository_dispatch events dorny/paths-filter's 'last commit' fallback mode for repository_dispatch is unreliable — it has no before/after SHAs and falls back to git log -n 1, which can misdetect changes depending on git history (e.g., initial commit shows all files as Added). Instead, openapi-generate-and-push.yml now passes api_versions in the dispatch payload. on-push-master.yml reads from the payload for dispatch events and only uses paths-filter for push events (which have proper SHAs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass api_version in repo dispatch instead of using paths-filter for repository_dispatch events
dorny/paths-filter's 'last commit' fallback mode for repository_dispatch is unreliable — it has no before/after SHAs and falls back to git log -n 1, which can misdetect changes
Instead, openapi-generate-and-push.yml now passes api_versions in the dispatch payload. on-push-master.yml reads from the payload for dispatch events and only uses paths-filter for push events (which have proper SHAs).