fix: add missing jquery.switchbutton includes to compose.manager.page#78
Open
wqcqj9rq5d-tech wants to merge 1 commit intomstrhakr:mainfrom
Open
fix: add missing jquery.switchbutton includes to compose.manager.page#78wqcqj9rq5d-tech wants to merge 1 commit intomstrhakr:mainfrom
wqcqj9rq5d-tech wants to merge 1 commit intomstrhakr:mainfrom
Conversation
compose_manager_main.php calls .switchButton() on lines 457 and 1459, but the required CSS and JS files were never loaded in compose.manager.page. This caused Autostart toggles and the Basic/Advanced View toggle to fail silently (switchButton: false).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: missing jquery.switchbutton includes
compose_manager_main.phpcalls.switchButton()in multiple places, butcompose.manager.pagenever loads the required CSS and JS files from Unraid's webGui.Symptoms:
switchButton: falseor$.fn.switchButton is not a functionFix:
Added the two missing includes to
compose.manager.pageafter the existingjquery.filetree.jsinclude:Tested on: Unraid 7.2.3