Conversation
Owner
ms609
commented
Mar 29, 2026
- SL_MAX_BINS: 32 -> 512, giving SL_MAX_TIPS = 64 * 512 = 32768
- Introduce SL_STACK_BINS (32) and SL_STACK_SPLITS (2045) as stack allocation thresholds, keeping SplitList objects at ~548 KB (not bloated)
- Trees with > 2048 tips use heap allocation in SplitList (transparent to callers)
- Update splits_to_tree.cpp to use stack thresholds for its local arrays
- Lookup table cost: ~1 MB (lg2 + lg2_double_factorial + lg2_unrooted)
- SL_MAX_BINS: 32 -> 512, giving SL_MAX_TIPS = 64 * 512 = 32768 - Introduce SL_STACK_BINS (32) and SL_STACK_SPLITS (2045) as stack allocation thresholds, keeping SplitList objects at ~548 KB (not bloated) - Trees with > 2048 tips use heap allocation in SplitList (transparent to callers) - Update splits_to_tree.cpp to use stack thresholds for its local arrays - Lookup table cost: ~1 MB (lg2 + lg2_double_factorial + lg2_unrooted)
Performance benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 96.06% 96.06%
=======================================
Files 80 80
Lines 5889 5890 +1
=======================================
+ Hits 5657 5658 +1
Misses 232 232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.