Skip to content

Drop stringi dependency#264

Merged
ms609 merged 1 commit intomainfrom
no-stringi
Mar 20, 2026
Merged

Drop stringi dependency#264
ms609 merged 1 commit intomainfrom
no-stringi

Conversation

@ms609
Copy link
Copy Markdown
Owner

@ms609 ms609 commented Mar 20, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (e370c31) to head (087bf30).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   96.13%   96.15%   +0.01%     
==========================================
  Files          79       80       +1     
  Lines        5846     5875      +29     
==========================================
+ Hits         5620     5649      +29     
  Misses        226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

Performance benchmark results

Call Status Change Time (ms)
as.Splits(bigTrees) ⚪ NSD -0.21% 28.5 →
28.6, 28.6
as.Splits(someTrees) ⚪ NSD -0.77% 9.98 →
10, 10.1
Consensus(forest1k.888, check = FALSE) ⚪ NSD 0.2% 83.8 →
83.9, 83.3
Consensus(forest201.80, check = FALSE) ⚪ NSD 0.44% 3.91 →
3.9, 3.89
Consensus(forest21.260, 0.5, FALSE) ⚪ NSD -0.4% 1.09 →
1.1, 1.09
Consensus(forest21.260) ⚪ NSD 0.46% 1.09 →
1.08, 1.08
Consensus(forestMaj, 0.5, FALSE) ⚪ NSD -0.86% 2.78 →
2.82, 2.78
DropTip(tr2000, 5) ⚪ NSD 2.08% 26.4 →
25.8, 25.9
DropTip(tr80, 5) ⚪ NSD 0.24% 0.0898 →
0.0901, 0.089
DropTip(unlen2k, 5) ⚪ NSD -6.67% 0.187 →
0.192, 0.242
DropTip(unlen80, 5) ⚪ NSD 0.34% 0.0342 →
0.0341, 0.034
lapply(bigSplits, as.phylo) ⚪ NSD -1.18% 27.3 →
27.4, 28.3
lapply(someSplits, as.phylo) ⚪ NSD 1% 11.8 →
11.5, 11.7
PathLengths(tr2000, full = TRUE) ⚪ NSD -0.21% 24.3 →
24.1, 24.6
PathLengths(tr80, full = TRUE) ⚪ NSD 2.32% 0.078 →
0.0754, 0.0771
PathLengths(tr80Unif, full = TRUE) ⚪ NSD 2.36% 0.0801 →
0.0777, 0.0789
RootTree(tr2000, 5) ⚪ NSD -0.25% 0.287 →
0.288, 0.287
RootTree(tr80, c("t3", "t36")) ⚪ NSD 0.18% 0.0556 →
0.0556, 0.0555
RootTree(tr80, "t3") ⚪ NSD 0.24% 0.0392 →
0.0391, 0.0391
RootTree(tr80, "t30") ⚪ NSD 0.21% 0.0392 →
0.0391, 0.0392
RootTree(unlen2k, 5) ⚪ NSD -6.08% 0.258 →
0.275, 0.273
RootTree(unlen80, c("t3", "t36")) ⚪ NSD 0.14% 0.0521 →
0.0518, 0.0522
RootTree(unlen80, "t3") ⚪ NSD 0.28% 0.0348 →
0.0346, 0.0348
RootTree(unlen80, "t30") ⚪ NSD 0.32% 0.035 →
0.0349, 0.0349
TreeDist::RobinsonFoulds(forest201.80) ⚪ NSD -1.32% 14.7 →
14.9, 14.8
TreeDist::RobinsonFoulds(forest21.888) ⚪ NSD -0.09% 2.9 →
2.91, 2.87
TreeTools:::path_lengths(tr80$edge, tr80$edge.length, FALSE) ⚪ NSD 0.15% 0.0698 →
0.0688, 0.0706
TreeTools:::postorder_order(bal40) ⚪ NSD -2.92% 0.00134 →
0.00132, 0.00139
TreeTools:::postorder_order(bal40k) ⚪ NSD -32.06% 0.311 →
0.414, 0.407
TreeTools:::postorder_order(dbal40) ⚪ NSD 0% 0.00154 →
0.00148, 0.00156
TreeTools:::postorder_order(dbal40k) ⚪ NSD -3.98% 2.18 →
2.27, 2.27
TreeTools:::postorder_order(dpec40) ⚪ NSD 0.42% 0.00233 →
0.00228, 0.00234
TreeTools:::postorder_order(dpec40k) 🟣 ~same 1.78% 4500 →
4420, 4430
TreeTools:::postorder_order(drnd80) ⚪ NSD -1.34% 0.0038 →
0.00382, 0.00387
TreeTools:::postorder_order(nbal40) ⚪ NSD 0.48% 0.00188 →
0.00186, 0.00187
TreeTools:::postorder_order(nbal40k) ⚪ NSD 0.37% 2.44 →
2.43, 2.43
TreeTools:::postorder_order(npec40) ⚪ NSD 1.35% 0.00267 →
0.00262, 0.00265
TreeTools:::postorder_order(npec40k) ⚪ NSD 1.24% 4470 →
4420, 4420
TreeTools:::postorder_order(nrnd80) ⚪ NSD -0.81% 0.0045 →
0.00453, 0.00455
TreeTools:::postorder_order(pec40) ⚪ NSD -1.11% 0.00136 →
0.00133, 0.00138
TreeTools:::postorder_order(pec40k) ⚪ NSD 1.62% 0.324 →
0.312, 0.401
TreeTools:::postorder_order(rnd80) ⚪ NSD -3.4% 0.00159 →
0.00161, 0.00167

@ms609 ms609 merged commit b70fece into main Mar 20, 2026
36 checks passed
@ms609 ms609 deleted the no-stringi branch March 20, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant