Skip to content

cpp_edge_to_splits_batch#263

Closed
ms609 wants to merge 2 commits intomainfrom
batch-as-splits-2
Closed

cpp_edge_to_splits_batch#263
ms609 wants to merge 2 commits intomainfrom
batch-as-splits-2

Conversation

@ms609
Copy link
Copy Markdown
Owner

@ms609 ms609 commented Mar 19, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026 •
edited
Loading

⚠️ This benchmark result is outdated. See the latest comment below.

Performance benchmark results

Call Status Change Time (ms)
as.Splits(bigTrees) 🟠 Slower 🙁 -27.81% 22 →
28.2, 27.9
as.Splits(someTrees) 🟠 Slower 🙁 -13.49% 11.1 →
12.3, 12.7
Consensus(forest1k.888, check = FALSE) ⚪ NSD -2.29% 94.6 →
97.1, 95.1
Consensus(forest201.80, check = FALSE) ⚪ NSD -1.43% 3.94 →
3.98, 4.01
Consensus(forest21.260, 0.5, FALSE) ⚪ NSD -1.49% 1.19 →
1.22, 1.2
Consensus(forest21.260) ⚪ NSD -0.94% 1.21 →
1.23, 1.21
Consensus(forestMaj, 0.5, FALSE) ⚪ NSD -1.17% 2.88 →
2.94, 2.9
DropTip(tr2000, 5) ⚪ NSD 1.9% 17.2 →
16.7, 17
DropTip(tr80, 5) ⚪ NSD -2.89% 0.102 →
0.104, 0.106
DropTip(unlen2k, 5) ⚪ NSD -2.49% 0.203 →
0.203, 0.21
DropTip(unlen80, 5) ⚪ NSD -1.72% 0.0395 →
0.0398, 0.0405
lapply(bigSplits, as.phylo) ⚪ NSD -0.86% 29 →
29.1, 29.7
lapply(someSplits, as.phylo) ⚪ NSD -3.11% 13.4 →
13.5, 14
PathLengths(tr2000, full = TRUE) 🟣 ~same -3.83% 15.8 →
16.4, 16.4
PathLengths(tr80, full = TRUE) ⚪ NSD 0.6% 0.113 →
0.111, 0.114
PathLengths(tr80Unif, full = TRUE) ⚪ NSD -0.09% 0.115 →
0.114, 0.117
RootTree(tr2000, 5) ⚪ NSD -6.18% 0.372 →
0.394, 0.396
RootTree(tr80, c("t3", "t36")) ⚪ NSD -2.02% 0.0686 →
0.07, 0.07
RootTree(tr80, "t3") ⚪ NSD -2.11% 0.0483 →
0.0495, 0.0492
RootTree(tr80, "t30") ⚪ NSD -1.75% 0.0488 →
0.0499, 0.0494
RootTree(unlen2k, 5) ⚪ NSD 2.41% 0.333 →
0.323, 0.327
RootTree(unlen80, c("t3", "t36")) ⚪ NSD -1.46% 0.0633 →
0.0641, 0.0643
RootTree(unlen80, "t3") ⚪ NSD -0.8% 0.0425 →
0.043, 0.0426
RootTree(unlen80, "t30") ⚪ NSD -1.31% 0.0428 →
0.0437, 0.043
TreeDist::RobinsonFoulds(forest201.80) ⚪ NSD -3.02% 15.5 →
15.7, 16.2
TreeDist::RobinsonFoulds(forest21.888) ⚪ NSD -2.05% 3.2 →
3.21, 3.28
TreeTools:::path_lengths(tr80$edge, tr80$edge.length, FALSE) ⚪ NSD 1.26% 0.104 →
0.101, 0.104
TreeTools:::postorder_order(bal40) ⚪ NSD -1.74% 0.00172 →
0.00175, 0.00175
TreeTools:::postorder_order(bal40k) ⚪ NSD -0.37% 0.428 →
0.423, 0.435
TreeTools:::postorder_order(dbal40) ⚪ NSD -2.26% 0.00177 →
0.0018, 0.00182
TreeTools:::postorder_order(dbal40k) ⚪ NSD 0.44% 2.04 →
2.03, 2.04
TreeTools:::postorder_order(dpec40) ⚪ NSD -1.94% 0.00259 →
0.00264, 0.00264
TreeTools:::postorder_order(dpec40k) 🟣 ~same 3.63% 3420 →
3300, 3300
TreeTools:::postorder_order(drnd80) ⚪ NSD -2.24% 0.00406 →
0.00414, 0.00416
TreeTools:::postorder_order(nbal40) ⚪ NSD -2.91% 0.00206 →
0.00211, 0.00214
TreeTools:::postorder_order(nbal40k) ⚪ NSD -0.05% 2.19 →
2.17, 2.2
TreeTools:::postorder_order(npec40) ⚪ NSD -1.77% 0.00288 →
0.00291, 0.00294
TreeTools:::postorder_order(npec40k) 🟣 ~same 3.47% 3440 →
3320, 3320
TreeTools:::postorder_order(nrnd80) ⚪ NSD -1.28% 0.00462 →
0.00465, 0.0047
TreeTools:::postorder_order(pec40) ⚪ NSD -2.41% 0.0017 →
0.00174, 0.00175
TreeTools:::postorder_order(pec40k) ⚪ NSD -0.4% 0.558 →
0.557, 0.565
TreeTools:::postorder_order(rnd80) ⚪ NSD -1.42% 0.00217 →
0.0022, 0.00221

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.13%. Comparing base (e370c31) to head (a5613d9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   96.13%   96.13%           
=======================================
  Files          79       79           
  Lines        5846     5848    +2     
=======================================
+ Hits         5620     5622    +2     
  Misses        226      226

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ms609 ms609 closed this Mar 20, 2026
@ms609 ms609 deleted the batch-as-splits-2 branch March 20, 2026 06:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Performance benchmark results

Call Status Change Time (ms)
as.Splits(bigTrees) ⚪ NSD -6.25% 21.9 →
22.4, 23.3
as.Splits(someTrees) ⚪ NSD 0.2% 11.1 →
11.1, 11
Consensus(forest1k.888, check = FALSE) ⚪ NSD -1.91% 94.7 →
97.1, 93.9
Consensus(forest201.80, check = FALSE) ⚪ NSD 0.18% 3.97 →
3.98, 3.94
Consensus(forest21.260, 0.5, FALSE) ⚪ NSD -1.23% 1.2 →
1.23, 1.21
Consensus(forest21.260) ⚪ NSD -0.76% 1.22 →
1.24, 1.22
Consensus(forestMaj, 0.5, FALSE) ⚪ NSD 0.13% 2.92 →
2.93, 2.89
DropTip(tr2000, 5) 🟣 ~same -1.78% 16.4 →
16.7, 16.6
DropTip(tr80, 5) ⚪ NSD -0.9% 0.104 →
0.105, 0.104
DropTip(unlen2k, 5) ⚪ NSD 1.7% 0.215 →
0.211, 0.211
DropTip(unlen80, 5) ⚪ NSD -1.58% 0.0405 →
0.0412, 0.0411
lapply(bigSplits, as.phylo) ⚪ NSD -0.05% 29.2 →
29.2, 29.2
lapply(someSplits, as.phylo) ⚪ NSD 0.29% 13.6 →
13.6, 13.4
PathLengths(tr2000, full = TRUE) ⚪ NSD 0.33% 15.8 →
15.7, 15.8
PathLengths(tr80, full = TRUE) ⚪ NSD -0.88% 0.112 →
0.113, 0.112
PathLengths(tr80Unif, full = TRUE) ⚪ NSD -0.78% 0.114 →
0.115, 0.114
RootTree(tr2000, 5) ⚪ NSD -2.35% 0.371 →
0.388, 0.369
RootTree(tr80, c("t3", "t36")) ⚪ NSD 0.01% 0.07 →
0.0704, 0.0694
RootTree(tr80, "t3") ⚪ NSD 0% 0.0498 →
0.0502, 0.0493
RootTree(tr80, "t30") ⚪ NSD 0.06% 0.0498 →
0.0502, 0.0491
RootTree(unlen2k, 5) ⚪ NSD 1.29% 0.332 →
0.323, 0.33
RootTree(unlen80, c("t3", "t36")) ⚪ NSD 0.69% 0.0649 →
0.0647, 0.0642
RootTree(unlen80, "t3") ⚪ NSD 0.3% 0.0433 →
0.0432, 0.0432
RootTree(unlen80, "t30") ⚪ NSD 0.66% 0.0439 →
0.0436, 0.0436
TreeDist::RobinsonFoulds(forest201.80) ⚪ NSD -1.06% 15.6 →
15.8, 15.7
TreeDist::RobinsonFoulds(forest21.888) ⚪ NSD -0.76% 3.23 →
3.24, 3.26
TreeTools:::path_lengths(tr80$edge, tr80$edge.length, FALSE) ⚪ NSD 0.02% 0.103 →
0.103, 0.103
TreeTools:::postorder_order(bal40) ⚪ NSD 2.72% 0.0018 →
0.00175, 0.00176
TreeTools:::postorder_order(bal40k) ⚪ NSD -0.04% 0.429 →
0.432, 0.428
TreeTools:::postorder_order(dbal40) ⚪ NSD -1.11% 0.00179 →
0.00181, 0.00181
TreeTools:::postorder_order(dbal40k) ⚪ NSD -3.04% 1.97 →
2.03, 2.04
TreeTools:::postorder_order(dpec40) ⚪ NSD 0% 0.00261 →
0.00261, 0.00261
TreeTools:::postorder_order(dpec40k) 🟣 ~same 1.3% 3420 →
3360, 3400
TreeTools:::postorder_order(drnd80) ⚪ NSD -1.48% 0.00405 →
0.00412, 0.00411
TreeTools:::postorder_order(nbal40) ⚪ NSD -1.43% 0.0021 →
0.00211, 0.00214
TreeTools:::postorder_order(nbal40k) ⚪ NSD -0.45% 2.2 →
2.18, 2.23
TreeTools:::postorder_order(npec40) ⚪ NSD 0.53% 0.00292 →
0.0029, 0.00291
TreeTools:::postorder_order(npec40k) ⚪ NSD 0.06% 3420 →
3420, 3420
TreeTools:::postorder_order(nrnd80) ⚪ NSD -0.21% 0.00462 →
0.00462, 0.00464
TreeTools:::postorder_order(pec40) ⚪ NSD 0% 0.00172 →
0.00172, 0.00172
TreeTools:::postorder_order(pec40k) ⚪ NSD -0.55% 0.557 →
0.56, 0.559
TreeTools:::postorder_order(rnd80) ⚪ NSD 0% 0.00218 →
0.00219, 0.00217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ms609