Security: Regular expression denial of service via unescaped user input#9370
Open
tuanaiseo wants to merge 1 commit intomozilla:masterfrom
Open
Conversation
The search string is split and each token is passed directly into `new RegExp(filter, 'i')`. A malicious user can supply catastrophic-backtracking patterns (for example nested quantifiers) that cause excessive CPU usage during filtering. Affected files: helpers.js Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The search string is split and each token is passed directly into
new RegExp(filter, 'i'). A malicious user can supply catastrophic-backtracking patterns (for example nested quantifiers) that cause excessive CPU usage during filtering.Severity:
mediumFile:
ui/push-health/helpers.jsSolution
Treat user input as literal text by escaping regex metacharacters before building a RegExp, or avoid regex entirely and use case-insensitive substring matching (
includes). Also cap input length and token count.Changes
ui/push-health/helpers.js(modified)Testing