feat(ui): replace push health counts with new counts#9361
Open
benoitgoupilleau wants to merge 3 commits intomozilla:masterfrom
Open
feat(ui): replace push health counts with new counts#9361benoitgoupilleau wants to merge 3 commits intomozilla:masterfrom
benoitgoupilleau wants to merge 3 commits intomozilla:masterfrom
Conversation
benoitgoupilleau
force-pushed
the
feat/UI-PushCounts
branch
from
c758d31 to
c0198b0
Compare
Archaeopteryx
approved these changes
Apr 1, 2026
ui/job-view/pushes/PushCounts.jsx
Outdated
| <> | ||
| {totalFailedJobs > 0 && ( | ||
| <Badge | ||
| bg="warning" |
Collaborator
There was a problem hiding this comment.
The failure count for pushes with jobs still in progress must not use the same color as the 'fixed by commit' badge. The latter has the warning type to tell people "Don't use this for production code". Could a different, non-bootstrap color be used (e.g. orange)?
Author
There was a problem hiding this comment.
I could also display them as they are displayed once all jobs are completed -> red background and white text.
What do you think?
Also for the fixed commit badge, I would add a text inside like "{fixedByCommit} fixed by commit"
benoitgoupilleau
force-pushed
the
feat/UI-PushCounts
branch
from
95d483b to
9347dc2
Compare
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of removing Push Health links, the push health counts are replaced with new counts based on the jobs data. This new count appears in the header bar for each revision.
When on try repo, after selecting a specific revision, additionally, details counts are displayed (Linting, Build and Tests)
Screenshots: