Skip to content

chore(google_gke): make logging config components configurable #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahoneiser wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −7
Open

chore(google_gke): make logging config components configurable #457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions google_gke/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,7 @@ module "gke" {
| <a name="input_grant_registry_access"></a> [grant\_registry\_access](#input\_grant\_registry\_access) | Grants created cluster-specific service account storage.objectViewer and artifactregistry.reader roles. | `bool` | `true` | no |
| <a name="input_kubernetes_version"></a> [kubernetes\_version](#input\_kubernetes\_version) | The Kubernetes version of the masters. If set to 'latest' it will pull latest available version. Defaults to 'latest'. | `string` | `"latest"` | no |
| <a name="input_labels"></a> [labels](#input\_labels) | The GCE resource labels (a map of key/value pairs) to be applied to the cluster & other cluster-related resources. Merged with default labels (see locals.tf). | `map(string)` | `{}` | no |
| <a name="input_logging_config_components"></a> [logging\_config\_components](#input\_logging\_config\_components) | n/a | `list(string)` | <pre>[<br/> "APISERVER",<br/> "CONTROLLER_MANAGER",<br/> "SCHEDULER",<br/> "SYSTEM_COMPONENTS",<br/> "WORKLOADS"<br/>]</pre> | no |
| <a name="input_maintenance_exclusions"></a> [maintenance\_exclusions](#input\_maintenance\_exclusions) | List of maintenance exclusions. A cluster can have up to three | `list(object({ name = string, start_time = string, end_time = string }))` | `[]` | no |
| <a name="input_maintenance_start_time"></a> [maintenance\_start\_time](#input\_maintenance\_start\_time) | Time window specified for daily or recurring maintenance operations in RFC3339 format | `string` | `"21:00"` | no |
| <a name="input_master_authorized_networks"></a> [master\_authorized\_networks](#input\_master\_authorized\_networks) | List of master authorized networks that can access the GKE Master Plane. If none are provided, it defaults to known Bastion hosts for the given realm. See locals.tf for defaults. | `list(object({ cidr_block = string, display_name = string }))` | <pre>[<br/> {<br/> "cidr_block": "192.0.0.8/32",<br/> "display_name": "tf module placeholder"<br/> }<br/>]</pre> | no |
Expand Down
8 changes: 1 addition & 7 deletions google_gke/cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,13 +107,7 @@ resource "google_container_cluster" "primary" {

# Observability
logging_config {
enable_components = [
"APISERVER",
"CONTROLLER_MANAGER",
"SCHEDULER",
"SYSTEM_COMPONENTS",
"WORKLOADS"
]
enable_components = var.logging_config_components
}

monitoring_config {
Expand Down
11 changes: 11 additions & 0 deletions google_gke/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,3 +448,14 @@ variable "enable_ray_cluster_monitoring" {
type = bool
default = true
}

variable "logging_config_components" {
type = list(string)
default = [
"APISERVER",
"CONTROLLER_MANAGER",
"SCHEDULER",
"SYSTEM_COMPONENTS",
"WORKLOADS"
]
}
Loading