Skip to content

Clarify Fenix building instructions#7290

Open
leplatrem wants to merge 11 commits intomainfrom
leplatrem-patch-1
Open

Clarify Fenix building instructions#7290
leplatrem wants to merge 11 commits intomainfrom
leplatrem-patch-1

Conversation

@leplatrem
Copy link
Copy Markdown
Contributor

@leplatrem leplatrem commented Mar 25, 2026 •
edited
Loading

Updated instructions for setting JAVA_HOME with a specific command.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@leplatrem
Clarify JAVA_HOME setup in Fenix building instructions
a34348a 
Updated instructions for setting JAVA_HOME with a specific command.
@leplatrem
Copy link
Copy Markdown
Contributor Author

leplatrem commented Mar 25, 2026

r? @sarah541

@leplatrem leplatrem requested a review from alexcottner March 25, 2026 17:16
@leplatrem leplatrem changed the title Clarify JAVA_HOME setup in Fenix building instructions Clarify Fenix building instructions Mar 25, 2026
alexcottner
alexcottner reviewed Mar 25, 2026
View reviewed changes
leplatrem
leplatrem commented Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some letter casing nits :)

alexcottner and others added 6 commits April 3, 2026 09:32
@alexcottner @leplatrem
Fixing casing and adding mac example
1fa1f7f 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@alexcottner @leplatrem
Fixing casing
bd1e373 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@alexcottner @leplatrem
Fixing casing
66d86d6 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@alexcottner @leplatrem
Fixing casing
a5fad7a 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@alexcottner @leplatrem
Fixing casing
aca5fbc 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
@alexcottner @leplatrem
Fixing casing and adding gradle example
db5b673 
Co-authored-by: Mathieu Leplatre <mathieu@mozilla.com>
alexcottner
alexcottner approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are some good clarifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcottner alexcottner alexcottner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@leplatrem @alexcottner