Conversation
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| # This file defines the metrics that will be gathered for the Remote Settings |
There was a problem hiding this comment.
Is this file even required?
Since technically the telemetry is done in consuming components (eg. kotlin)
There was a problem hiding this comment.
It's required if you want to check in the Kotlin code in app-services to implement the metrics (e.g. you could define a RemoteSettingsTelemetry implementation that firefox-android could use). Also you might want to use this PR for data review. If neither of those is true, then I don't think it's needed.
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
The code looks good to me, but a couple notes:
- If this is a new metric, then it'll need data review.
- Jan-Erik is working on a system for reporting Glean metrics directly from Rust. The ETA is somewhere around the start of H2, but that's not set in stone. So, if there's no deadline for this you may want to wait for that to land and everything gets easier. If there is a deadline, then you probably don't want to wait.
There was a problem hiding this comment.
I think this got checked in by accident.
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| # This file defines the metrics that will be gathered for the Remote Settings |
There was a problem hiding this comment.
It's required if you want to check in the Kotlin code in app-services to implement the metrics (e.g. you could define a RemoteSettingsTelemetry implementation that firefox-android could use). Also you might want to use this PR for data review. If neither of those is true, then I don't think it's needed.
This reverts commit 0b2bb38.
3 participants
Pull Request checklist
[ci full]to the PR title.