feat(ads-client): add reason parameter to report_ad per MARS /v1/t spec#7268
Open
Almaju wants to merge 5 commits intomozilla:mainfrom
Open
feat(ads-client): add reason parameter to report_ad per MARS /v1/t spec#7268Almaju wants to merge 5 commits intomozilla:mainfrom
Almaju wants to merge 5 commits intomozilla:mainfrom
Conversation
Almaju
force-pushed
the
ads-client-report-ad
branch
from
9dfccc0 to
4dfc45d
Compare
The /v1/t tracking endpoint requires a `reason` query parameter for report interactions. Add MozAdsReportReason enum with Inappropriate, NotInterested, and SeenTooManyTimes variants and thread it through the full stack, appending it to the callback URL before the request.
…gration tests against prod Switch integration tests from staging to production. Add tests that request tile ads and use the returned callback URLs to verify record_impression, record_click, and report_ad each return 200.
Almaju
force-pushed
the
ads-client-report-ad
branch
from
3b715db to
934eb44
Compare
… URLs Add `add_placement_info_to_report_callbacks` on `AdResponse`, mirroring the existing `add_request_hash_to_callbacks` pattern. Called right after it in `request_ads`, it appends `placement_id` and 0-based `position` to each ad's report URL at parse time so `report_ad` sends all three params required by the MARS /v1/t spec without any API change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /v1/t tracking endpoint requires a
reasonquery parameter for report interactions. Add MozAdsReportReason enum with Inappropriate, NotInterested, and SeenTooManyTimes variants and thread it through the full stack, appending it to the callback URL before the request.Pull Request checklist
[ci full]to the PR title.