Feat: sequencer rotate support#28
Open
tomatoishealthy wants to merge 5 commits intofeat/pbft_to_singleSeqfrom
Open
Feat: sequencer rotate support#28tomatoishealthy wants to merge 5 commits intofeat/pbft_to_singleSeqfrom
tomatoishealthy wants to merge 5 commits intofeat/pbft_to_singleSeqfrom
Conversation
tomatoishealthy
requested review from
twcctop
and removed request for
a team
7 tasks
added 3 commits
February 26, 2026 15:59
…de height 1. Add continue FOR_LOOP after successful handleTheLastTMBlock to prevent fall-through to type assertion secondSync.(*types.Block) which panics when secondSync is *types.BlockV2. 2. Populate BlockID in nilCommit to prevent 'commit cannot be for nil block' panic on node restart when LoadSeenCommit validates the commit. 3. Use RedoRequest instead of PopRequest on error for proper retry handling.
… mode After upgrade, the SeenCommit for the last TM block has no valid signatures. Skip reconstructLastCommit and allow nil LastCommit in updateToState when already in sequencer mode, since consensus won't run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
CHANGELOG_PENDING.mdupdated, or no changelog entry neededdocs/) and code comments, or nodocumentation updates needed