fix: use correct Go pseudo-version for ETHEREUM_TARGET_VERSION#915
fix: use correct Go pseudo-version for ETHEREUM_TARGET_VERSION#915tomatoishealthy wants to merge 1 commit intomainfrom
Conversation
morph-v2.2.0 is a git tag name, not a valid Go module version. The update_mod sed pattern (v[0-9][^[:space:]]*) cannot match it, so future `make update` runs would silently skip go-ethereum version replacement. Set it to the actual pseudo-version that corresponds to the morph-v2.2.0 tag commit (62952ec7d188). ETHEREUM_SUBMODULE_COMMIT_OR_TAG remains morph-v2.2.0 as it is only used for git checkout, not Go module resolution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Makefile's ETHEREUM_TARGET_VERSION variable is updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ETHEREUM_TARGET_VERSIONwas set tomorph-v2.2.0(a git tag name) in PR feature: update go mod & submodule #914, but this is not a valid Go module versionupdate_modsed patternv[0-9][^[:space:]]*cannot matchmorph-v2.2.0(starts withm), which would silently break futuremake updaterunsv1.10.14-0.20260313031710-62952ec7d188that corresponds to themorph-v2.2.0tag commitETHEREUM_SUBMODULE_COMMIT_OR_TAGremainsmorph-v2.2.0(correct, only used forgit checkout)Test plan
make updateand verify all go.mod files retain the correct go-ethereum pseudo-versionmake submodulesand verify go-ethereum checks out to the morph-v2.2.0 tag🤖 Generated with Claude Code
Summary by CodeRabbit