Skip to content

fix: use correct Go pseudo-version for ETHEREUM_TARGET_VERSION#915

Closed
tomatoishealthy wants to merge 1 commit intomainfrom
fix/ethereum-target-version
Closed

fix: use correct Go pseudo-version for ETHEREUM_TARGET_VERSION#915
tomatoishealthy wants to merge 1 commit intomainfrom
fix/ethereum-target-version

Conversation

@tomatoishealthy
Copy link
Contributor

@tomatoishealthy tomatoishealthy commented Mar 13, 2026

Summary

  • ETHEREUM_TARGET_VERSION was set to morph-v2.2.0 (a git tag name) in PR feature: update go mod & submodule #914, but this is not a valid Go module version
  • The Makefile update_mod sed pattern v[0-9][^[:space:]]* cannot match morph-v2.2.0 (starts with m), which would silently break future make update runs
  • Fixed by setting it to the actual Go pseudo-version v1.10.14-0.20260313031710-62952ec7d188 that corresponds to the morph-v2.2.0 tag commit
  • ETHEREUM_SUBMODULE_COMMIT_OR_TAG remains morph-v2.2.0 (correct, only used for git checkout)

Test plan

  • Run make update and verify all go.mod files retain the correct go-ethereum pseudo-version
  • Run make submodules and verify go-ethereum checks out to the morph-v2.2.0 tag

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated Ethereum dependency version to the latest release.

morph-v2.2.0 is a git tag name, not a valid Go module version. The
update_mod sed pattern (v[0-9][^[:space:]]*) cannot match it, so
future `make update` runs would silently skip go-ethereum version
replacement. Set it to the actual pseudo-version that corresponds to
the morph-v2.2.0 tag commit (62952ec7d188).

ETHEREUM_SUBMODULE_COMMIT_OR_TAG remains morph-v2.2.0 as it is only
used for git checkout, not Go module resolution.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@tomatoishealthy tomatoishealthy requested a review from a team as a code owner March 13, 2026 10:39
@tomatoishealthy tomatoishealthy requested review from Web3Jumb0 and removed request for a team March 13, 2026 10:39
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3cd264f0-3f3d-4fa2-a17c-0c36b1fd41d4

📥 Commits

Reviewing files that changed from the base of the PR and between 86cd1bb and ca92874.

📒 Files selected for processing (1)
  • Makefile

📝 Walkthrough

Walkthrough

The Makefile's ETHEREUM_TARGET_VERSION variable is updated from morph-v2.2.0 to v1.10.14-0.20260313031710-62952ec7d188, pinning the project to a different Ethereum/geth build target.

Changes

Cohort / File(s) Summary
Version Update
Makefile
Updated ETHEREUM_TARGET_VERSION from morph-v2.2.0 to v1.10.14-0.20260313031710-62952ec7d188, changing the pinned geth commit reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • panos-xyz
  • FletcherMan
  • Web3Jumb0

Poem

🐰 A version bump, so swift and small,
We hop to update Ethereum's call,
From morph to geth, the target's new,
One line changed, yet builds run true!
The blockchain bounces with our care,
Version pinned with rabbit flair! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: use correct Go pseudo-version for ETHEREUM_TARGET_VERSION' directly and specifically describes the main change in the PR: updating a Makefile variable from an invalid git tag to a valid Go pseudo-version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ethereum-target-version
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant