feat: use router.replace for project filters to prevent history pollution#5378
Open
Qu1et-x wants to merge 4 commits intomodrinth:mainfrom
Open
feat: use router.replace for project filters to prevent history pollution#5378Qu1et-x wants to merge 4 commits intomodrinth:mainfrom
Qu1et-x wants to merge 4 commits intomodrinth:mainfrom
Conversation
IMB11
added
frontend
IMB11
requested changes
Feb 16, 2026
| > | ||
| <template v-if="mode === 'navigation'"> | ||
| <NuxtLink | ||
| replace |
Member
There was a problem hiding this comment.
This would cause all places where navtabs is used to use history.replaceState instead of history.pushState - breaking back navigation - not the right way to approach this.
Member
There was a problem hiding this comment.
Should have a prop to toggle this - and use the prop on the project page + search page
Member
There was a problem hiding this comment.
+ collection + user + org pages
Author
There was a problem hiding this comment.
Thank you for your feedback, I am modifying the code, and this may take a while
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #4335