fix: Remove logging initialization from MCPServer.__init__
#2004
+1
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1656
How Has This Been Tested?
Breaking Changes
Removed
mcp.server.mcpserver.utilities.logging.configure_loggingTypes of changes
Checklist
Additional context
I removed
mcp.server.mcpserver.utilities.logging.configure_logging, as this was the only usage.I also checked the examples, and most of them had
logging.basicConfigin them or no logging at all.I was uncertain about moving the call to
configure_loggingtoMCPServer.run_sse_asyncorMCPServer.run_streamable_http_asyncbecause they set up uvicorn with logging. However, I ultimately decided against it.