-
Notifications
You must be signed in to change notification settings - Fork 3.1k
refactor: replace lowlevel Server decorators with on_* constructor kwargs #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maxisbey
wants to merge
24
commits into
main
Choose a base branch
from
sketch/lowlevel-server-v2-kwargs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,523
−5,481
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2a5ebec
refactor: replace lowlevel Server decorators with on_* constructor kw…
maxisbey 2b9e8c7
fix: remove unnecessary request_ctx contextvar from notification hand…
maxisbey a7779e1
fix: address PR review comments on migration docs and type hints
maxisbey b2dc1af
fix: collapse single-arg Server() to one line in migration example
maxisbey e7a6e5f
refactor: replace _create_handler_kwargs with private methods on MCPS…
maxisbey e0fc054
refactor: use dict instead of list of tuples for handler maps
maxisbey 56e4ada
docs: document keyword-only Server constructor params in migration guide
maxisbey 5e4274a
refactor: inline _register_default_task_handlers into enable_tasks
maxisbey 032ebb2
feat: add on_* handler kwargs to enable_tasks for custom task handlers
maxisbey 9b77527
refactor: drop explicit Any from ServerRequestContext, rely on Reques…
maxisbey b466beb
refactor: make ExperimentalHandlers generic on LifespanResultT
maxisbey edf4833
refactor: type MCPServer handler signatures instead of Any
maxisbey 7801dc3
refactor: type notify as ClientNotification, remove getattr
maxisbey 5fd17d1
fix: resolve pyright errors in ExperimentalHandlers.enable_tasks
maxisbey 178d41f
fix: advertise subscribe capability when handler is registered
maxisbey ca8fd2e
refactor: make on_ping non-optional with default handler per MCP spec
maxisbey f4c256f
fix: update tests to use new Server constructor kwargs pattern
maxisbey b3f817f
fix: migrate experimental task server tests to new handler pattern
maxisbey c72c2dc
fix: migrate tests to new Server constructor kwargs pattern
maxisbey 793b144
fix: skip partial task capability tests
maxisbey 8da8b7b
fix: migrate examples and snippets to new Server constructor kwargs p…
maxisbey 92f0de5
fix: update README.v2.md prose to match new low-level Server API
maxisbey f61ca1f
fix: improve test coverage across lowlevel server and experimental tasks
maxisbey c1a7020
fix: cover experimental property cache-hit branch and fix completion …
maxisbey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.