-
Notifications
You must be signed in to change notification settings - Fork 1
chore: replace Super-Linter to streamline ci-cd #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c8914ed
chore: replace Super-Linter to streamline ci-cd
mobilemind 914b28d
chore: use actionlint locally, not in ci/cd
mobilemind 953df35
chore(copilot): update instructions that were stale
mobilemind db2833b
chore(linting): update preflight linting & README badge
mobilemind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,58 +10,59 @@ on: | |||||||||
|
|
||||||||||
| permissions: | ||||||||||
| contents: read | ||||||||||
| statuses: write | ||||||||||
|
|
||||||||||
| # Prevent concurrent runs for the same PR/branch | ||||||||||
| concurrency: | ||||||||||
| group: ${{ github.workflow }}-${{ github.ref }} | ||||||||||
| cancel-in-progress: true | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| build: | ||||||||||
| lint: | ||||||||||
| name: "Lint Code Base" | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| timeout-minutes: 10 | ||||||||||
|
|
||||||||||
| steps: | ||||||||||
| # Checkout the code base | ||||||||||
| - name: "Checkout Code" | ||||||||||
| uses: actions/checkout@v6 | ||||||||||
| with: | ||||||||||
| # Full git history needed to get list of changed files w/in `super-linter` | ||||||||||
| fetch-depth: 0 | ||||||||||
|
|
||||||||||
| # Setup Node.js with cache | ||||||||||
| - name: "Setup Node.js" | ||||||||||
| uses: actions/setup-node@v6 | ||||||||||
| with: | ||||||||||
| node-version: '24.x' | ||||||||||
| cache: 'npm' | ||||||||||
|
|
||||||||||
| # install | ||||||||||
| - name: "Install Dependencies" | ||||||||||
| run: npm ci --prefer-offline | ||||||||||
|
|
||||||||||
| # Run project's ESLint | ||||||||||
| - name: "Run ESLint" | ||||||||||
| run: npx eslint --config .github/linters/eslint.config.js . | ||||||||||
| - name: "Run ESLint" | ||||||||||
| run: npx eslint . | ||||||||||
|
|
||||||||||
| - name: "Lint Markdown" | ||||||||||
| run: npx markdownlint-cli2 "**/*.md" "#node_modules" "#dist" | ||||||||||
|
|
||||||||||
| - name: "Lint YAML" | ||||||||||
| run: | | ||||||||||
| pip install --quiet yamllint | ||||||||||
| yamllint . | ||||||||||
|
Comment on lines
+46
to
+47
|
||||||||||
| pip install --quiet yamllint | |
| yamllint . | |
| pip install --quiet yamllint==1.35.1 | |
| yamllint -c .github/linters/.yaml-lint.yml . |
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown linting is run via
markdownlint-cli2, but no explicit configuration is provided. Since this PR adds.markdownlint.jsonwith custom rules, consider ensuring the workflow actually loads that config (otherwise the new rules may not be enforced).