Skip to content

feat(CartesianChart): add progressbar to chart tooltip#2408

Open
Lisa18289 wants to merge 5 commits intomainfrom
2334-feedback-to-stacked-values-in-areachart-cartesianchart
Open

feat(CartesianChart): add progressbar to chart tooltip#2408
Lisa18289 wants to merge 5 commits intomainfrom
2334-feedback-to-stacked-values-in-areachart-cartesianchart

Conversation

@Lisa18289
Copy link
Copy Markdown
Member

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 82.24% 264 / 321
🔵 Statements 82.56% 270 / 327
🔵 Functions 89.85% 62 / 69
🔵 Branches 71.34% 122 / 171
File CoverageNo changed files found.
Generated in workflow #4975 for commit 3d60828 by the Vitest Coverage Report Action

@Lisa18289 Lisa18289 enabled auto-merge (squash) March 26, 2026 12:01
@Lisa18289 Lisa18289 changed the title 2334 feedback to stacked values in areachart cartesianchart feat(CartesianChart): add progressbar to chart tooltip Mar 26, 2026
@mfal
Copy link
Copy Markdown
Member

mfal commented Mar 27, 2026

I would prefer a more flexible/composable way of rendering a progressbar inside a tooltip. This aligns more with Flows style and DX of composing components.

Gladly the existing formatter already provides this kind of flexibility and composability.

Instead of

<ChartTooltip showProgressbar />

we could provide a ChartTooltipProgressBar that has a chart | payload prop and all the existing props from the regular <ProgressBar />.

This could be used inside the formatter, with all the flexibility of a render function.

<ChartTooltip formatter={
  (index, payload) => <ChartTooltipProgressBar payload={payload} {/* more settings */} /> }
/>
  1. Yes, this is more verbose, but lets you define any tooltip layout you want.
  2. The formatters signature does not match the example. We should talk about options, if go this way.

@mfal mfal self-requested a review March 27, 2026 13:00
value: number;
title: string;
color?: CategoricalColor;
color?: CategoricalColor | string;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have CategoricalWithCustomColor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feedback to Stacked Values in AreaChart (CartesianChart)

3 participants