Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR cuts the fmcd v0.8.0 release by adding a generated CHANGELOG.md for the release and updating the Rust dependency lockfile to reflect the resolved versions for this release.
Changes:
- Add
CHANGELOG.mdwith the v0.8.0 release notes (generated by git-cliff / release-plz). - Update
Cargo.lockwith refreshed dependency resolutions consistent with the currentCargo.tomlconstraints.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Cargo.lock | Updates locked dependency graph for the v0.8.0 release build. |
| CHANGELOG.md | Introduces the v0.8.0 changelog content for release notes/distribution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - Impl handle config | ||
| - Impl list operations | ||
| - Impl backup | ||
| - Impl backup |
There was a problem hiding this comment.
The Features list includes the same bullet (“Impl backup”) twice in a row, which looks like an accidental duplication in the generated changelog. Consider deduplicating or clarifying if these refer to distinct changes.
Suggested change
| - Impl backup |
| - :> changed the type of field in DecodeNotesResponse struct and MintSpendResponse | ||
| - :> Added test suite for MINT METHODS | ||
| - :> Added test suite for ONCHAIN METHODS | ||
| - :> Transfered all TEST function to main.go and mirrored them with fedimint-ts |
There was a problem hiding this comment.
Typo in changelog entry: “Transfered” should be “Transferred”.
Suggested change
| - :> Transfered all TEST function to main.go and mirrored them with fedimint-ts | |
| - :> Transferred all TEST function to main.go and mirrored them with fedimint-ts |
| - :> updated some parameters | ||
| - :> Made some changes in parameters of func | ||
| - :> Mirrored python tests with go tests + updated just.local files | ||
| - :> discover_version now takes threshold as a copulsory input |
There was a problem hiding this comment.
Typo in changelog entry: “copulsory” should be “compulsory”.
Suggested change
| - :> discover_version now takes threshold as a copulsory input | |
| - :> discover_version now takes threshold as a compulsory input |
| - Fix | ||
| - Finish db refactor | ||
| - Workspace version | ||
| - Geet it building |
There was a problem hiding this comment.
Typo in changelog entry: “Geet” should be “Get”.
Suggested change
| - Geet it building | |
| - Get it building |
Reorganize fmcd from monolithic binary into single crate that publishes both library and binary, following FMCD_LIBBIN.md design. Changes: - Move business logic to src/core/ (multimint, operations, services) - Move API handlers to src/api/ (REST routes, WebSocket handlers) - Create FmcdCore as central business logic interface - Add library entry point at src/lib.rs, binary at src/bin/main.rs - Simplify AppState to delegate to FmcdCore, removing duplication - Add 'api' feature flag to make web dependencies optional - Refactor handlers as thin wrappers around core methods This enables fmcd to be used as a Rust library while preserving all existing API functionality. Core business logic is now separate from HTTP concerns, improving testability and maintainability.
…ulation - Fix zero balance bug by using client.get_balance() instead of only counting mint notes - Remove duplicate implementations between FmcdCore and API layers - Implement PaymentInfoResolver trait pattern for LNURL handling without coupling core to web protocols - Move all business logic (get_info, join_federation, create_invoice, pay_invoice) to FmcdCore - Make API layer a thin wrapper that delegates to FmcdCore methods - Add proper error handling and context propagation throughout
okjodom
force-pushed
the
release-plz-2026-03-25T03-06-44Z
branch
from
d77c472 to
0d5b23b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
fmcd: 0.8.0Changelog
This PR was generated with release-plz.