Fixed minor edge case bug in enum mapping

[michelebastione]

Now when exporting an enum value outside of the explicitly defined ones the number will be written instead of a blank space.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a subtle bug in how enum values are converted to strings for cell values within the MiniExcel.OpenXml library. Previously, if an enum value did not have a corresponding name (e.g., an invalid underlying integer value), the system could fail to retrieve a description or provide an empty one. The update introduces a more robust fallback mechanism, ensuring that a string representation is always provided, enhancing the reliability of enum serialization.

Highlights

• Enum Mapping Robustness: Improved handling of enum values in the GetCellValue method to prevent null reference exceptions or incorrect descriptions when Enum.GetName returns null or an empty string, ensuring a valid string representation is always provided.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/MiniExcel.OpenXml/OpenXmlWriter.DefaultOpenXml.cs
  • Fixed an edge case where Enum.GetName could return null or an empty string, leading to an incorrect or missing description for enum values.
  • Implemented a fallback to value.ToString() if a valid enum name and description cannot be determined.

Activity

• No specific activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a bug in enum value handling, specifically for cases where enum values lack a defined name, by correctly falling back to value.ToString(). However, it introduces a security vulnerability by failing to XML-encode the resulting Enum description, which could lead to XML Injection if the description contains special characters. Additionally, there's an opportunity to refactor the implementation for improved readability and conciseness.