New package: PlantUML.PlantUML version v1.2023.9

[seppeon]

I've made a manifest for PlantUML, which at this time does not work. I need some assistance fixing an issue.

• Have you signed the Contributor License Agreement?
• Have you checked that there aren't other open pull requests for the same manifest update/change?
• This PR only modifies one (1) manifest
• Have you validated your manifest locally with winget validate --manifest <path>?
• Have you tested your manifest locally with winget install --manifest <path>?
• Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

---

Microsoft Reviewers: codeflow:open?pullrequest=#110767

[wingetbot]

   

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[seppeon]

I need some help with this one:

1. There is an issue where the standalone .jar file is renamed to .exe.
2. I'd like to add a dependency to the OpenJDK or java runtime if possible.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[stephengillie]

##[warning] Validation concluded that this task needs to go to manual review.

[stephengillie]

Manual Validation failed with:

1:55:31 PM: C:\Users\User\AppData\Local\Microsoft\WinGet\Links\plantuml.jar.exe
start-process : This command cannot be run due to the error: The specified executable is not a valid application for this OS platform..

[stephengillie]

This appears to be a portable JAR file.

• Should Orcale.JavaRuntimeEdition or similar be a dependency?
• The portable InstallerType appears to be appending a .exe to the file name. Another InstallerType might be needed, though I'm unsure of a better type.

[seppeon]

I think yeah, Orcale.JavaRuntimeEdition seems sensible.

Thanks, yeah I'd have to bounce it back to the original author in that case. Is there a downside adding support for .jar in winget-cli, I have read through the code, it doesn't appear to be particularly complicated. There is a renaming function that performs a rename operation on the filenames that appear in the URL, it assumes anything standalone is .exe (and renames the extension with that assumption), remove that assumption and I believe it may work. I got that code building, but for some reason it ran the unmodified version lol, so I'll have to look at it again tonight.

The lines in question for winget-cli are in DownloadFlow.cpp, in the internally linked function called GetInstallerFileExtension.

[seppeon]

Ok so I've put this PR up.
microsoft/winget-cli#3385

I think that might resolve the renaming issue. My main issue now is, I have no idea where wingetdev saves its files so I cannot check if its working.

[denelon]

As raised in:

• Portable executable not supported for non-exe targets winget-cli#3386

I think the best thing to do here is raise a more explicit error when the portable package doesn't have the .exe extension.

We're going to have more work to do around reasoning how WinGet should handle a Java Archive as a "portable" package.

[denelon]

• Support Java Archives as a portable package type winget-cli#3387

[denelon]

We've got the issues open that would be required to approve a PR for a portable-jar. I'm going to go ahead and close this PR. Be sure to upvote/follow the two issues mentioned above.