Skip to content

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905 to main#21121

Merged
kburtram merged 1 commit intomainfrom
lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905
Feb 9, 2026
Merged

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905 to main#21121
kburtram merged 1 commit intomainfrom
lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905

Conversation

@csigs
Copy link
Member

@csigs csigs commented Feb 7, 2026

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905 to main with localized lcls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VS Code MSSQL extension localization (LCL) resources by adding new localized strings (primarily for Profiler-related UI and settings) across multiple languages.

Changes:

  • Adds new localized bundle strings for Profiler UI/actions/status text.
  • Adds new localized package setting strings for Profiler configuration (e.g., event buffer size, launch command).
  • Updates LCL files for multiple locales (zh-Hans, pt-BR, ko, it, fr, de).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
localization/LCL/zh-Hans/vscode-mssql.xlf.lcl Adds new Simplified Chinese translations for newly introduced Profiler-related strings.
localization/LCL/pt-BR/vscode-mssql.xlf.lcl Adds new Brazilian Portuguese translations for newly introduced Profiler-related strings.
localization/LCL/ko/vscode-mssql.xlf.lcl Adds new Korean translations for newly introduced Profiler-related strings.
localization/LCL/it/vscode-mssql.xlf.lcl Adds new Italian LCL entries for newly introduced Profiler-related strings and settings.
localization/LCL/fr/vscode-mssql.xlf.lcl Adds new French LCL entries for newly introduced Profiler-related strings and settings.
localization/LCL/de/vscode-mssql.xlf.lcl Adds new German translations for newly introduced Profiler-related strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Str Cat="Text">
<Val><![CDATA[Stopping profiler session "{0}"...]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Profiler 세션 "을(를) 중지하는 중"{0}"...]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Korean translation for "Stopping profiler session "{0}"..." has the placeholder and quotes in the wrong order (currently renders with broken punctuation). Adjust the translation so the session name placeholder {0} remains inside the quotes, matching the source ordering.

Suggested change
<Val><![CDATA[Profiler 세션 "을(를) 중지하는 중"{0}"...]]></Val>
<Val><![CDATA[Profiler 세션 "{0}"을(를) 중지하는 중...]]></Val>

Copilot uses AI. Check for mistakes.
</Item>
<Item ItemId=";bundle.++CODE++07a70d0f8dcd3b512fbe302a9052f2a7c309d8ef1a2d6279bb2fec89a8037514" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newly added string is missing a translation block, so Italian users will see the English source text. Please add the appropriate (and audit the other newly added Profiler-related entries in this file that also appear to be missing ).

Suggested change
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Impossibile connettersi al server selezionato.]]></Val>
</Tgt>

Copilot uses AI. Check for mistakes.
Comment on lines +17076 to +17082
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new package setting strings were added without a translation block, so they will remain in English in the Italian localization. Please add translations for these new Profiler settings entries.

Suggested change
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Numero massimo di eventi da mantenere in memoria per Profiler. Quando viene raggiunto questo limite, gli eventi meno recenti vengono eliminati. Aumentare questo valore se è necessario conservare più eventi durante le sessioni di profilatura.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Avvia Profiler]]></Val>
</Tgt>

Copilot uses AI. Check for mistakes.
</Item>
<Item ItemId=";bundle.++CODE++07a70d0f8dcd3b512fbe302a9052f2a7c309d8ef1a2d6279bb2fec89a8037514" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newly added string is missing a translation block, so French users will see the English source text. Please add the appropriate (and audit the other newly added Profiler-related entries in this file that also appear to be missing ).

Suggested change
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
<Val><![CDATA[Failed to connect to the selected server.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Échec de la connexion au serveur sélectionné.]]></Val>
</Tgt>

Copilot uses AI. Check for mistakes.
Comment on lines +17076 to +17082
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new package setting strings were added without a translation block, so they will remain in English in the French localization. Please add translations for these new Profiler settings entries.

Suggested change
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
<Val><![CDATA[Maximum number of events to keep in memory for the Profiler. When this limit is reached, older events are dropped. Increase this value if you need to retain more events during profiling sessions.]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Nombre maximal d’événements à conserver en mémoire pour le profileur. Lorsque cette limite est atteinte, les événements les plus anciens sont supprimés. Augmentez cette valeur si vous devez conserver davantage d’événements pendant les sessions de profilage.]]></Val>
</Tgt>
</Str>
<Disp Icon="Str" />
</Item>
<Item ItemId=";package.mssql.profiler.launchFromObjectExplorer" ItemType="0" PsrId="308" Leaf="true">
<Str Cat="Text">
<Val><![CDATA[Launch Profiler]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[Lancer le profileur]]></Val>
</Tgt>

Copilot uses AI. Check for mistakes.
<Str Cat="Text">
<Val><![CDATA[Engine: {0}]]></Val>
<Tgt Cat="Text" Stat="Loc" Orig="New">
<Val><![CDATA[引擎:: {0}]]></Val>
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Simplified Chinese translation for "Engine: {0}" contains a duplicated colon ("引擎:: {0}") which looks like a typo and will show incorrectly in the UI. Update it to use a single colon to match the source string formatting.

Suggested change
<Val><![CDATA[引擎:: {0}]]></Val>
<Val><![CDATA[引擎: {0}]]></Val>

Copilot uses AI. Check for mistakes.
@kburtram
Copy link
Member

kburtram commented Feb 9, 2026

Unrelated CI failures. Merging to clean up PR queue.

@kburtram kburtram merged commit 608996b into main Feb 9, 2026
7 of 9 checks passed
@kburtram kburtram deleted the lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260207163733905 branch February 9, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants