Remove Preview tag for publishDialog and make it ready for GA

[ssreerama]

Pull Request Template – vscode-mssql

Description

This PR:

• removes the Preview tag from the publishDialog
• removes the old publish quickpick flow entry point
• removes the related tests of cleanup code

Code Changes Checklist

• New or updated unit tests added
• All existing tests pass (npm run test)
• Code follows contributing guidelines
• Telemetry/logging updated if relevant
• No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

[Copilot]

Pull request overview

Removes “Preview” branding from the SQL Database Projects publish dialog and removes the legacy quickpick-based publish entry point, aligning the publish experience for GA while also improving generated tasks.json build task behavior.

Changes:

• Removed the legacy sqlDatabaseProjects.publish command/flow and standardized on publishDialog (now labeled “Publish”).
• Updated localization strings to drop “(Preview)” and added new strings related to tasks.json updates/errors.
• Refactored SQL project build task generation (no longer template-based) and updated/removed related tests/templates.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
localization/xliff/vscode-mssql.xlf	Removes “Publish Project (Preview)” source string from base XLF.
localization/xliff/sql-database-projects.xlf	Renames publish command label to “Publish” and updates tasks.json-related strings.
extensions/sql-database-projects/test/templates.test.ts	Updates expected template count after removing tasks template.
extensions/sql-database-projects/test/projectController.test.ts	Updates stubs and assertions after publish flow removal + tasks.json changes.
extensions/sql-database-projects/test/buildHelper.test.ts	Updates assertions and imports for build helper behavior.
extensions/sql-database-projects/src/tools/buildHelper.ts	Uses constants for MSBuild argument strings/prefixes.
extensions/sql-database-projects/src/templates/templates.ts	Stops loading tasks.json template.
extensions/sql-database-projects/src/projectProvider/projectProvider.ts	Routes publish action to publishProjectDialog.
extensions/sql-database-projects/src/models/project.ts	Replaces hardcoded project style names with constants.
extensions/sql-database-projects/src/controllers/projectController.ts	Removes old publish flow; refactors tasks.json generation + adds telemetry/error handling.
extensions/sql-database-projects/src/controllers/mainController.ts	Removes old publish command registration.
extensions/sql-database-projects/src/common/utils.ts	Adds helpers for generating tasks.json and SQL project build tasks.
extensions/sql-database-projects/src/common/telemetry.ts	Adds new telemetry action for tasks.json errors.
extensions/sql-database-projects/src/common/constants.ts	Adds tasks.json/build-task constants and localized messages.
extensions/sql-database-projects/resources/templates/tasksTemplate.json	Deletes the old tasks.json template file.
extensions/sql-database-projects/package.nls.json	Renames publish dialog title to “Publish” and removes old publish command title.
extensions/sql-database-projects/package.json	Removes sqlDatabaseProjects.publish command contribution and menu entries.
extensions/sql-database-projects/l10n/bundle.l10n.json	Updates localized bundle strings for tasks.json messaging.
extensions/sql-database-projects/CHANGELOG.md	Adds notes for the next release including tasks.json behavior fix.
extensions/mssql/src/constants/locConstants.ts	Updates publish dialog title to “Publish Project”.
extensions/mssql/l10n/bundle.l10n.json	Removes unused “Publish Project (Preview)” localization entry.

Comments suppressed due to low confidence (2)

extensions/sql-database-projects/src/controllers/projectController.ts:345

• createBuildTaskForProject adds legacy-only MSBuild properties that point at the extension BuildDirectory, but nothing ensures the required legacy build assets (targets/DLLs) have been initialized there before a user runs the generated tasks.json task. This can cause the default Build task to fail for legacy-style projects when invoked via VS Code tasks. Consider either initializing the build directory during project creation for legacy projects, or generating a task that uses the extension’s build flow that performs the initialization first.

	 * @returns path of the built dacpac
	 */
	public async buildProject(treeNode: dataworkspace.WorkspaceTreeItem, codeAnalysis?: boolean): Promise<string>;
	/**
	 * Builds a project, producing a dacpac

localization/xliff/sql-database-projects.xlf:1257

• The base sql-database-projects XLF updates sqlDatabaseProjects.publishDialog to "Publish" and removes the old sqlDatabaseProjects.publish entry, but the locale-specific sql-database-projects.*.xlf files still contain the old "Publish (Preview)" source/entries. If locale XLFs are expected to match the base file, they should be updated to avoid stale/mismatched localization data.

    <trans-unit id="sqlDatabaseProjects.schemaCompare">
      <source xml:lang="en">Schema Compare</source>
    </trans-unit>
    <trans-unit id="sqlDatabaseProjects.updateProjectFromDatabase">
      <source xml:lang="en">Update Project From Database</source>
    </trans-unit>

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

PR Changes

Category	Target Branch	PR Branch	Difference
vscode-mssql VSIX	5911 KB	5911 KB	⚪ 0 KB ( 0% )
sql-database-projects VSIX	7877 KB	7875 KB	⚪ -2 KB ( 0% )
data-workspace VSIX	537 KB	537 KB	⚪ 0 KB ( 0% )

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.27%. Comparing base (e08cb5d) to head (652f27c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #21118   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         242      242           
  Lines       23554    23554           
  Branches     3116     3116           
=======================================
  Hits        16082    16082           
  Misses       7343     7343           
  Partials      129      129           

Files with missing lines	Coverage Δ
extensions/mssql/src/constants/locConstants.ts	87.72% <100.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.