Replace deprecated request package with axios in SQL Database Projects#21085
Draft
Replace deprecated request package with axios in SQL Database Projects#21085
Conversation
Co-authored-by: kburtram <599935+kburtram@users.noreply.github.com>
Co-authored-by: kburtram <599935+kburtram@users.noreply.github.com>
Co-authored-by: kburtram <599935+kburtram@users.noreply.github.com>
Co-authored-by: kburtram <599935+kburtram@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove deprecated request npm package for SQL Project
Replace deprecated request package with axios in SQL Database Projects
Feb 3, 2026
aasimkhan30
reviewed
Feb 3, 2026
|
|
||
| const contentLengthHeader = response.headers['content-length']; | ||
| const totalBytes = parseInt(contentLengthHeader || '0'); | ||
| const totalMegaBytes = totalBytes / (1024 * 1024); |
Contributor
There was a problem hiding this comment.
NIT: Maybe consolidate bytes to megabytes calculation and add a function in general utils.ts.
aasimkhan30
approved these changes
Feb 3, 2026
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21085 +/- ##
=======================================
Coverage 67.89% 67.89%
=======================================
Files 230 230
Lines 22394 22394
Branches 2971 2971
=======================================
Hits 15204 15204
Misses 7059 7059
Partials 131 131 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
requestnpm package (deprecated since Feb 2020) was used for streaming file downloads in SQL Database Projects. Replaced withaxioswhich the extension already uses elsewhere.Key Changes:
requestand@types/requestdependenciesHttpClient.download()to use axios streaming (responseType: 'stream')Implementation:
Preserves all existing behavior: progress tracking, timeout handling, error reporting.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.