-
Notifications
You must be signed in to change notification settings - Fork 570
Profiler start session on load #21074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
allancascante
wants to merge
27
commits into
main
Choose a base branch
from
dev/allancascante/profiler_start_session_on_load
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+878
−44
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
3921de1
Profiler STS Integration, adding UI foundation, multi-session support…
980587f
lint error fixes
470bf5f
fix for eventClass mapping
e8fec4e
adding configuration for profiler buffer size
d9427f0
refactor on file structure
bbad598
adding tests
4b8b0a7
disabling grid options
a67042e
grid row display updates
63b9830
Merge remote-tracking branch 'origin' into dev/allancascante/profiler…
8d5dc67
added launch to object explorer menu and updated label
2ae5f10
linter fixes
d139422
Merge branch 'main' into dev/allancascante/profiler_integration
c217f70
Merge branch 'dev/allancascante/profiler_integration' of https://gith…
870259f
fixing linter errors
7f6269f
localization changes
6e27b14
PR feedback
115e1b2
fixing linter error
ec7b62d
logic to ask user to select session template and session name to crea…
7653dde
filter azure and on prem templates depending of the connections, addi…
dc73b7e
Merge branch 'dev/allancascante/profiler_start_session_on_load' into …
97f7837
Merge branch 'main' into dev/allancascante/profiler_start_session_on_…
c20cdf7
Merge remote-tracking branch 'origin' into dev/allancascante/profiler…
9b1ede7
pr comments
9ef5a7e
Merge branch 'main' into dev/allancascante/profiler_start_session_on_…
767d5ec
Merge branch 'main' into dev/allancascante/profiler_start_session_on_…
4934003
Merge remote-tracking branch 'origin' into dev/allancascante/profiler…
c010d25
localization updates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warning text
noDatabasesFoundis shown when no user databases remain after filtering out system DBs, but the message says “No databases found on the server…”. This can be misleading when the server only returns system databases. Consider adjusting the string to explicitly mention “no user databases found” (or similar) to match the actual condition.