Open
Conversation
aasimkhan30
requested review from
Benjin,
allancascante,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21069 +/- ##
=======================================
Coverage 68.29% 68.29%
=======================================
Files 242 242
Lines 23543 23548 +5
Branches 3114 3117 +3
=======================================
+ Hits 16078 16083 +5
Misses 7336 7336
Partials 129 129
🚀 New features to boost your workflow:
|
added 6 commits
January 30, 2026 18:34
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds "(Preview)" labels to database management dialogs (Create Database, Drop Database, and Rename Database) and implements loading indicators for Create and Drop database operations. The changes ensure users are aware these are preview features and receive visual feedback during long-running operations.
Changes:
- Added "(Preview)" suffix to database dialog titles in command palette and webview tabs
- Implemented loading state management with spinners and status messages for create/drop database operations
- Enhanced ObjectManagementWebviewController architecture to support separate dialog and webview titles
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| localization/xliff/vscode-mssql.xlf | Added localization entries for "(Preview)" labels and loading messages |
| extensions/mssql/src/reactviews/pages/ObjectManagement/dropDatabaseDialogPage.tsx | Added isSubmitting state management and loading indicator for drop operations |
| extensions/mssql/src/reactviews/pages/ObjectManagement/createDatabaseDialogPage.tsx | Added isSubmitting state management and loading indicator for create operations |
| extensions/mssql/src/reactviews/common/objectManagementDialog.tsx | Added support for displaying loading messages with spinner component |
| extensions/mssql/src/reactviews/common/locConstants.ts | Updated dialog titles to include "(Preview)" and added loading message strings |
| extensions/mssql/src/controllers/objectManagementWebviewController.ts | Added webviewTitle parameter with documentation to separate internal and user-facing titles |
| extensions/mssql/src/controllers/dropDatabaseWebviewController.ts | Updated constructor to accept webviewTitle parameter |
| extensions/mssql/src/controllers/createDatabaseWebviewController.ts | Updated constructor to accept webviewTitle parameter |
| extensions/mssql/src/controllers/backupDatabaseWebviewController.ts | Updated to pass dialogTitle for both parameters (maintains existing behavior) |
| extensions/mssql/src/constants/locConstants.ts | Added webview title constants for create and drop database dialogs |
| extensions/mssql/package.nls.json | Updated command labels to include "(Preview)" |
| extensions/mssql/l10n/bundle.l10n.json | Added localization entries for preview labels and loading messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines