-
Notifications
You must be signed in to change notification settings - Fork 570
Fix: creating SQL project inside already open workspace results in tasks definition in wrong spot #20985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix: creating SQL project inside already open workspace results in tasks definition in wrong spot #20985
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
15ee5d0
initial changes
ssreerama 6767671
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama b8b34b8
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama 8b2063d
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama 45f37e3
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama 32ecd9a
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama 04d7e2f
Merge branch 'main' of https://github.com/microsoft/vscode-mssql
ssreerama 9901eb3
all changes complete, need to update tests if we have any
ssreerama fb24d28
loc
ssreerama 0891c2c
improvements
ssreerama ae51225
updating changelog
ssreerama 0b2c425
Merge branch 'main' into sai/bug_TaskDefWrongPlace
ssreerama 144d08d
fixing test with task.json removal
ssreerama f398f72
addressing copilot review comments
ssreerama 7896816
comments addressed
ssreerama 1154f23
LOC
ssreerama 7595651
Merge branch 'main' into sai/bug_TaskDefWrongPlace
ssreerama 6e4731f
Merge branch 'main' into sai/bug_TaskDefWrongPlace
ssreerama e17bb5f
adding const to constants file and throwing error
ssreerama 9e453ba
remove comment for absense of the else block
ssreerama c51dc21
updating the test to follow new pattern
ssreerama 5328027
Merge branch 'main' into sai/bug_TaskDefWrongPlace
ssreerama dba88a2
updating the recently merged test that follows old pattern
ssreerama 4e5b2a5
test fixes
ssreerama bfd8d76
remove dead constant
ssreerama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
extensions/sql-database-projects/resources/templates/tasksTemplate.json
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.