Fix kit detection returning 'unknown vendor' when using clang-cl#4687
Draft
Fix kit detection returning 'unknown vendor' when using clang-cl#4687
Conversation
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix kit detection for clang-cl to avoid unknown vendor
Fix kit detection returning 'unknown vendor' when using clang-cl
Feb 3, 2026
Contributor
Co-authored-by: snehara99 <113148726+snehara99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses item #4638
This changes visible behavior
The following changes are proposed:
detectVendorFromBinaryPath()helper to detect vendor from compiler binary path (clang-cl, clang, gcc patterns)getKitDetect()to use binary path detection as fallback when kit name patterns don't matchscanDirForClangForMSVCKits()to generate 'Clang-cl' prefixed names for clang-cl.exe kitsThe purpose of this change
${buildKitVendor}expanded to__unknown_vendor__when using clang-cl.exe because vendor detection relied solely on kit names starting with specific patterns ('Clang-cl', 'Clang ', 'GCC '). Manually added kits or auto-scanned kits often had different naming.Before:
After:
Other Notes/Information
Vendor detection patterns supported:
clang-cl,clang-cl-*→ ClangClclang,clang-*→ Clanggcc,gcc-*,*-gcc,*-gcc-*→ GCCUnit tests added for vendor detection from binary paths including versioned compilers and cross-compilers.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.