Add a regexp for problem matching on the msvc linker output#4675
Open
bradphelan wants to merge 3 commits intomicrosoft:mainfrom
Open
Add a regexp for problem matching on the msvc linker output#4675bradphelan wants to merge 3 commits intomicrosoft:mainfrom
bradphelan wants to merge 3 commits intomicrosoft:mainfrom
Conversation
hanniavalera
force-pushed
the
problem-matcher-linker
branch
from
c19a39e to
bbd47de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses item #4077
It doesn't specifically fix #4077 but it adds the missing problem matcher for MSVC linker errors.
Problem
When running CMake: build with msvc all the build errors are found and added to the problems pane. However linker errors are not found.
This is of particular concern with using github copilot in an agent loop. The agent expects to be able to see the problems via get_errors and if the linker errors are lost then the llm gets very confused because it will see that the build has completed and then it will proceed to run my tests which may not have been built and then it goes quickly downhill.
I've made a separate REGEX for the linker to avoid messing with the already complex regexp used for the compiler. This means two regexp per line which I hope is not considered bad form or a performance issue.