add reusable package for managing windows shims#2601
Open
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Open
add reusable package for managing windows shims#2601rawahars wants to merge 1 commit intomicrosoft:mainfrom
rawahars wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Existing `containerd-shim-runhcs-v1` was tightly coupled with the code used for managing the shim lifecycle and other boilerplate code. Since we are adding new shims for Windows, the newly added `shim` package will be used for the boilerplate management code. This commit adds the same. Signed-off-by: Harsh Rawat <harshrawat@microsoft.com>
rawahars
force-pushed
the
feat/shim-pkg
branch
from
785f197 to
61fe5f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new reusable Windows containerd shim bootstrap package. The main goal is to provide a generic, shareable shim entrypoint and eventing logic to avoid code duplication across Windows shim binaries.
Key changes:
Shim Bootstrap Implementation:
pkg/shimpackage, which provides a reusable shim entrypoint for Windows containerd shims, handling CLI commands (start,serve,delete), ttrpc server setup, event publishing, and logging. Includes a detailedREADME.mdwith usage instructions and responsibilities.Core Logic:
servecommand to set up ttrpc server, handle log redirection, event publishing, and clean shutdowns.deletecommand to clean up container resources, handle panic logs, and ensure protocol-compliant responses.shim.go, including ETW logging and OpenCensus tracing.Event Publishing Infrastructure:
Publisherinterface andeventPublisherimplementation for sending task events back to containerd, including OpenCensus tracing integration.Testing:
Documentation:
README.mdfor the new shim package, describing its purpose, usage, and integration points for consumers.