fix: msdsn improvements for TrustServerCertificate and IPv6#312
Open
dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: msdsn improvements for TrustServerCertificate and IPv6#312dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
dlevy-msft-sql wants to merge 1 commit intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR provides two independent improvements to the msdsn package: adding a TrustServerCertificate field to the Config struct and fixing IPv6 address formatting in generated URLs.
Changes:
- Adds
TrustServerCertificateboolean field toConfigstruct to expose this connection parameter to callers - Fixes
Config.URL()to properly bracket IPv6 addresses when combined with ports (e.g.,[::1]:1433instead of::1:1433) - Updates
parseTLSfunction signature to return the trustServerCert value for storage in Config
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 75.36% 78.59% +3.23%
==========================================
Files 34 34
Lines 6597 6598 +1
==========================================
+ Hits 4972 5186 +214
+ Misses 1337 1134 -203
+ Partials 288 278 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ba87d10 to
2fcbb73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent fixes to the msdsn package:
Changes
1. TrustServerCertificate Field
Adds
TrustServerCertificateboolean field tomsdsn.Configstruct, making this important connection parameter accessible to callers.2. IPv6 URL Generation Fix
Fixes
Config.URL()to properly bracket IPv6 addresses in generated URLs, preventing malformed URLs likesqlserver://user@::1:1433(now correctly generatessqlserver://user@[::1]:1433).Split from #306 for easier review