BulkLoad: Fix some types

[dlapko]

No description provided.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.29213% with 30 lines in your changes missing coverage. Please review.

Project coverage is 74.98%. Comparing base (ba24acc) to head (6babea6).

Files with missing lines	Patch %	Lines
bulkcopy.go	60.29%	23 Missing and 4 partials ⚠️
types.go	85.71%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   74.77%   74.98%   +0.21%     
==========================================
  Files          32       32              
  Lines        6457     6540      +83     
==========================================
+ Hits         4828     4904      +76     
- Misses       1338     1343       +5     
- Partials      291      293       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shueybubbles]

would it be worthwhile to have a non-bulkinsert test case for this? #Resolved

[dlapko]

@shueybubbles I don’t see any insert tests anywhere…
Besides, this code won’t run in non-bulkinsert scenario because:

func (s *Stmt) makeParam(val driver.Value) (res param, err error) {
	if val == nil {
		res.ti.TypeId = typeNull
		res.buffer = nil
		res.ti.Size = 0
		return
	}
        ...

And then

func writeTypeInfo(w io.Writer, ti *typeInfo, out bool, encoding msdsn.EncodeParameters) (err error) {
	err = binary.Write(w, binary.LittleEndian, ti.TypeId)
	if err != nil {
		return
	}
	switch ti.TypeId {
	case typeNull, typeInt1, typeBit, typeInt2, typeInt4, typeDateTim4,
		typeFlt4, typeMoney, typeDateTime, typeFlt8, typeMoney4, typeInt8:
		// those are fixed length
		// https://msdn.microsoft.com/en-us/library/dd341171.aspx
		ti.Writer = writeFixedType
	...

[dlapko]

@microsoft-github-policy-service agree