Conversation
|
@CL-Jeremy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 74.79% 74.30% -0.50%
==========================================
Files 32 31 -1
Lines 6379 6370 -9
==========================================
- Hits 4771 4733 -38
- Misses 1325 1352 +27
- Partials 283 285 +2 ☔ View full report in Codecov by Sentry. |
1d28ec6 to
b976a9d
Compare
b976a9d to
f604e19
Compare
| t.Errorf("invalid type returned for typeFlt4") | ||
| } | ||
| if (reflect.TypeOf(float64(0)) != makeGoLangScanType(typeInfo{TypeId: typeFlt8})) { | ||
| t.Errorf("invalid type returned for typeDateTime") |
There was a problem hiding this comment.
love those copy/paste bugs
|
Sorry for doing this kind of trial-and-error trying to come up with a test case for #208. Temporarily out of ideas. |
First attempt to see if CI breaks (expected with current code).