test: add recordings for new cp tests#153
Open
v-alexmoraru wants to merge 15 commits intomicrosoft:mainfrom
Open
test: add recordings for new cp tests#153v-alexmoraru wants to merge 15 commits intomicrosoft:mainfrom
v-alexmoraru wants to merge 15 commits intomicrosoft:mainfrom
Conversation
ohadedry
reviewed
Feb 18, 2026
| metadata = EntityMetadata( | ||
| generated_name, virtual_workspace_name, virtual_workspace_item_path | ||
| ) | ||
| metadata.type = type |
Contributor
There was a problem hiding this comment.
Why not adding the type to the ctor if you already defined it in the ctor?
| # Teardown: remove everything we created during the test | ||
| for metadata in created_virtual_workspace_items: | ||
| if vcr_mode == "none" and metadata.type == VirtualWorkspaceType.CAPACITY: | ||
| continue |
Contributor
There was a problem hiding this comment.
Can you please explain this change?
| @@ -5,6 +5,7 @@ | |||
| import os | |||
| import shutil | |||
| import tempfile | |||
| import pytest | |||
Contributor
There was a problem hiding this comment.
where does pytest is used in this file?
| @@ -294,18 +297,20 @@ def test_cp_workspace_to_folder_success( | |||
| rm(copied_notebook.full_path) | |||
| rm(copied_eventhouse.full_path) | |||
|
|
|||
| @cp_item_types_success_params | |||
| def test_cp_item_to_item_success( | |||
Contributor
There was a problem hiding this comment.
Does test_cp_item_to_item_success.yaml is still required?
| @@ -382,18 +387,21 @@ def test_cp_item_to_item_type_mismatch_failure( | |||
| # Assert | |||
| assert_fabric_cli_error(constant.ERROR_UNSUPPORTED_COMMAND) | |||
|
|
|||
| def test_cp_virtual_workspace_item_domain_not_supported_failure( | |||
| @cp_virtual_workspace_item_failure_params | |||
| def test_cp_virtual_workspace_item_not_supported_failure( | |||
Contributor
There was a problem hiding this comment.
Does test_cp_virtual_workspace_item_domain_not_supported_failure.yaml is still required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.