Conversation
…icate without calling super. This caused missing CFG children.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chanel-y identified two PowerShell issues:
The first issue was that this code:
did not select the
newcall in[Microsoft.Data.SqlClient.SqlConnectionStringBuilder]::new(...).Turns out this was because we didnt have type information regarding
Microsoft.Data.SqlClient.SqlConnectionStringBuilderas this data is not in the XML files we have extracted from https://github.com/dotnet/dotnet-api-docs. Instead, this data is generated directly from the C# code stored at https://github.com/dotnet/SqlClient.So to get those types I wrote a query and a script to generate type models from C# databases. I also amended the
README.mdfile to describe this process so that we can extend it if we encounter other cases like this (which I'm sure we will).With these models things Just Work 🎉
The next issue was that this code:
did not find the
$hostingConnectionStringinNew-Object Microsoft.Data.SqlClient.SqlConnectionStringBuilder -ArgumentList $hostingConnectionString.The problem was that we forgot to call
super.relevantChildwhen we were extending certainChildMappings in the CFG classes. This meant that CFG nodes forNew-Objects had no arguments! This has been fixed in 2eb8b1a, and the result can be seen in 2b4ac31