Open
Conversation
08b5585 to
3101e5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
Task Name
AzureWebApp
Description
Introduced a new API that in azure pipeline common tasks - microsoft/azure-pipelines-tasks-common-packages#568
This will be called before any deployment to make kudu container available.
Risk Assessment (Low / Medium / High)
Low.
This is to optimize the deployment and everything is in try catch.
Change Behind Feature Flag (Yes / No)
Can this change be behind feature flag, if not why?
There is no need to add this behind feature flag.
There was a previous API, instead of that we will be calling new api.. its not going to create any error in deployment.
Its just optimization
Tech Design / Approach
Discussed with owning team.
Documentation Changes Required (Yes/No)
Indicate whether related documentation needs to be updated.
NA
Unit Tests Added or Updated (Yes / No)
Indicate whether unit tests were added or modified to reflect these changes.
Additional Testing Performed
List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).
Tested the changes on a prod canary app by pushing the task in my testing feed.
https://dev.azure.com/kumaraksh/Test/_build/results?buildId=85&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=7ead7f30-9997-5ce5-fb3b-d8df586a067d
Logging Added/Updated (Yes/No)
Added debug logs and only needed.
Telemetry Added/Updated (Yes/No)
NA
Rollback Scenario and Process (Yes/No)
We just to revert this task.
Dependency Impact Assessed and Regression Tested (Yes/No)
No other module will be impacted because of this.
Checklist