Skip to content

Remove duplicated RadioButtons page#2102

Open
Zakariathr22 wants to merge 3 commits intomicrosoft:mainfrom
Zakariathr22:refactor/radiobutton-page-cleanup
Open

Remove duplicated RadioButtons page#2102
Zakariathr22 wants to merge 3 commits intomicrosoft:mainfrom
Zakariathr22:refactor/radiobutton-page-cleanup

Conversation

@Zakariathr22
Copy link
Contributor

Description

Main changes are;

  • Moved the example from the RadioButtons page to the RadioButton page
  • Removed the redundant RadioButtons page
  • Updated ControlInfoData.json accordingly
  • Removed RadioButtons.png from assets

Motivation and Context

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- Moved the example from the RadioButtons page to the RadioButton page
- Removed the redundant RadioButtons page
- Updated ControlInfoData.json accordingly
- Removed RadioButtons.png from assets
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we had this in the first place. Probably because RadioButtons was added later on?

Anyways, great work! Tested, and approved!

@niels9001 niels9001 enabled auto-merge (squash) February 8, 2026 16:47
@niels9001
Copy link
Collaborator

/azp run

1 similar comment
@marcelwgn
Copy link
Contributor

/azp run

@marcelwgn marcelwgn disabled auto-merge February 9, 2026 08:35
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should converge into the RadioButtons page instead of RadioButton. There are very little use cases for the RadioButton control (without s), you would probably almost always use a RadioButtons control. Before RadioButtons, RadioButton was the only option and it did some grouping via key logic and walking the tree (iirc), but now thats no longer necessary. RadioButtons is the easier and better option for most scenarios.

"ApiNamespace": "Microsoft.UI.Xaml.Controls",
"Subtitle": "A control that allows a user to select a single option from a group of options.",
"ImagePath": "ms-appx:///Assets/ControlImages/RadioButton.png",
"Description": "Use RadioButtons to let a user choose between mutually exclusive, related options. Generally contained within a RadioButtons group control.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Description": "Use RadioButton controls to let a user choose between mutually exclusive, related options. Generally contained within a RadioButtons group control.",

To differentiate between the two very different items

@Jay-o-Way
Copy link
Contributor

Did we lose this link?
image

@Zakariathr22
Copy link
Contributor Author

I think we should converge into the RadioButtons page instead of RadioButton. There are very little use cases for the RadioButton control (without s), you would probably almost always use a RadioButtons control. Before RadioButtons, RadioButton was the only option and it did some grouping via key logic and walking the tree (iirc), but now thats no longer necessary. RadioButtons is the easier and better option for most scenarios.

@marcelwgn, should it be in the controls section or the layouts section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate RadioButtons sample in Basic Input and Layout sections

4 participants