Implement LWG-4037 Static data members of ctype_base are not yet required to be usable in constant expressions
#6079
+55
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4506.
Remarks: The constants are put into a new base class to avoid affecting DLL interface. I've verified this with
dumpbin /export msvcp140_oss.dll(with unchanged output).Initially I thought it might be wanted to keep these constants enumerators (which are prvalues), see also LWG-3998. However, it seems intentional that
ctype_base::maskisshort(as shown by the comment), and it's impossible to make enumerators be of typeshort. So now I think it's better to do what the standard says, which also avoids type mismatch.