Skip to content

CmdPal: Improvements and fixes for icon loading#45460

Merged
michaeljolley merged 2 commits intomicrosoft:mainfrom
jiripolasek:feature/45438-icon-cache-gremlins
Feb 9, 2026
Merged

CmdPal: Improvements and fixes for icon loading#45460
michaeljolley merged 2 commits intomicrosoft:mainfrom
jiripolasek:feature/45438-icon-cache-gremlins

Conversation

@jiripolasek
Copy link
Collaborator

@jiripolasek jiripolasek commented Feb 6, 2026

Summary of the Pull Request

This PR is a follow-up for Icon cache:

  • Adds decoding and rasterization limit (by width) to reduce memory usage and improves throughput (noticeably)
  • Fixes timing issue when setting padding for font icons
  • Resolves race condition in IconBox caused by incorrect guard

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

- Fix timing issue when setting padding for font icons
- Resolve race condition in IconBox caused by incorrect guard
- Add decoding and rasterization limit (by width) to reduce memory usage and improve throughput
@jiripolasek jiripolasek added Product-Command Palette Refers to the Command Palette utility In for .98 labels Feb 6, 2026
@github-actions

This comment has been minimized.

Copy link
Contributor

@michaeljolley michaeljolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@michaeljolley michaeljolley merged commit a02a5a9 into microsoft:main Feb 9, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

In for .98 Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants