Fix the requires_grad adjustment logic in mark_only_lora_as_trainable#125
Open
MikuAndRabbit wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix the requires_grad adjustment logic in mark_only_lora_as_trainable#125MikuAndRabbit wants to merge 1 commit intomicrosoft:mainfrom
MikuAndRabbit wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to the
mark_only_lora_as_trainablemethod to setrequires_gradto True for parameters withlora_in the name.This change was made for the following reason.
Sometimes
requires_gradmay be set to False for all parameters of the whole model before calling themark_only_lora_as_trainablemethod, and if following the logic of the existingmark_only_lora_as_trainablemethod, therequires_gradof the parameter whose name containslora_is still set to False after calling, which I think has some conflict with the method namemark_only_lora_as_trainable.