Fix for #612 original megadetector constructors had invalid version string. #613
Open
podgorki wants to merge 1 commit intomicrosoft:mainfrom
Open
Fix for #612 original megadetector constructors had invalid version string. #613podgorki wants to merge 1 commit intomicrosoft:mainfrom
podgorki wants to merge 1 commit intomicrosoft:mainfrom
Conversation
… megadetector defaults to a valid versions
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612
Default version string in the init for MegaDetectorV6MIT, MegaDetectorV6_Distributed, MegaDetectorV6, MegaDetectorV6Apache were incorrect.
I updated the default to match the first value in the if else statement which selects the correct weights. Apache version was -x which as far as I can see does not exist so I followed the pattern for the rest and set the default as the first value in the if else string