Export-import object types with UUID retention by CharString · Pull Request #745 · maykinmedia/objects-api

CharString · 2026-03-16T14:33:41Z

Fixes #565

Changes

Adds export to file action, and import from file to objecttype admin.

codecov-commenter · 2026-03-16T14:37:43Z

Codecov Report

❌ Patch coverage is 99.20635% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.37%. Comparing base (8d03167) to head (ec33c14).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/objects/core/import_export.py	98.86%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
+ Coverage   85.58%   86.37%   +0.79%     
==========================================
  Files         144      145       +1     
  Lines        3003     3142     +139     
  Branches      236      253      +17     
==========================================
+ Hits         2570     2714     +144     
+ Misses        381      376       -5     
  Partials       52       52

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-03-16T14:43:04Z

Bencher Report

Branch	565-exportimport-object-types-with-uuid-retention
Testbed	ubuntu-24.04

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_by_object_type	📈 view plot 🚷 view threshold	129.48 ms (+2.57%) Baseline: 126.25 ms	132.56 ms (97.68%)
performance_test/tests/test_objects_list.py::test_objects_api_list_filter_one_result	📈 view plot 🚷 view threshold	20.25 ms (+0.85%) Baseline: 20.08 ms	21.09 ms (96.04%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_1	📈 view plot 🚷 view threshold	336.00 ms (+3.29%) Baseline: 325.29 ms	341.56 ms (98.37%)
performance_test/tests/test_objects_list.py::test_objects_api_list_large_page_size_page_5	📈 view plot 🚷 view threshold	340.61 ms (+1.39%) Baseline: 335.93 ms	352.73 ms (96.56%)
performance_test/tests/test_objects_list.py::test_objects_api_list_small_page_size_page_20	📈 view plot 🚷 view threshold	130.72 ms (+2.13%) Baseline: 128.00 ms	134.40 ms (97.27%)

🐰 View full continuous benchmarking report in Bencher

Also updated their dependencies to solve import and api issues.

Hacked it into a bounds check.

Queryset is never empty; django admin already checks this when performing an action.

requirements/test-tools.in

src/objects/core/tests/test_admin.py

src/objects/core/tests/test_export_import.py

src/objects/core/admin.py

CharString · 2026-03-17T14:47:01Z

src/objects/templates/admin/core/objecttype/object_import_form.html

+                    {{ form.non_field_errors }}
+                </div>
+            {% endif %}
            <fieldset class="module aligned">


This "aligned" class makes field errors look visually "off" to my eyes (huge left margin). But it already looked like that...

Hmm yeah it definitely looks off, could you remove the aligned class to make it look a bit better?

stevenbal

@CharString could you add some basic documentation under Manual to describe how to do exports and imports?

stevenbal · 2026-03-19T13:36:38Z

src/objects/templates/admin/core/objecttype/object_import_form.html

+                    {{ form.non_field_errors }}
+                </div>
+            {% endif %}
            <fieldset class="module aligned">


Hmm yeah it definitely looks off, could you remove the aligned class to make it look a bit better?

stevenbal · 2026-03-19T14:48:40Z

src/objects/core/forms.py

+    )
+    keep_uuid = forms.BooleanField(
+        label=_("Keep the UUIDs the same"),
+        help_text=_("Import keeping the same UUID as in the export."),


Suggested change

help_text=_("Import keeping the same UUID as in the export."),

help_text=_("Import keeping the same UUIDs as in the export."),

src/objects/core/admin.py

stevenbal · 2026-03-19T14:56:42Z

src/objects/core/import_export.py

+
+    class Meta(_ObjectTypeSerializer.Meta):
+        fields = [
+            field for field in _ObjectTypeSerializer.Meta.fields if field not in ["url"]


Suggested change

field for field in _ObjectTypeSerializer.Meta.fields if field not in ["url"]

field for field in _ObjectTypeSerializer.Meta.fields if field != "url"

Co-authored-by: Steven Bal <steven@maykinmedia.nl>

Still not super pretty, but .aligned has a lot of left margin, which looks very off.

CharString · 2026-03-20T15:50:14Z

@CharString could you add some basic documentation under Manual to describe how to do exports and imports?

@stevenbal I've put the documentation under Admin interface / object types where the other object type actions documented. But it can be moved of course.

CharString linked an issue Mar 16, 2026 that may be closed by this pull request

Export/Import Object Types with UUID Retention #565

Open

CharString force-pushed the 565-exportimport-object-types-with-uuid-retention branch 3 times, most recently from b40b7ce to 67eed69 Compare March 16, 2026 20:28

CharString changed the title ~~565 exportimport object types with UUID retention~~ Export-import object types with UUID retention Mar 17, 2026

CharString force-pushed the 565-exportimport-object-types-with-uuid-retention branch 3 times, most recently from 8e11b96 to dc54480 Compare March 17, 2026 13:25

CharString added 8 commits March 17, 2026 14:27

✨ [#565] Implement import_export similar to OF and OZ

722e73e

➕ [#565] Add hypothesis and hypothesis-jsonschema for testing

a769776

Also updated their dependencies to solve import and api issues.

✅ [#565] Test import export

e52c9c2

✨ [#565] Add export action and import tool to admin

b2691d6

✅ [#565] Fix a NumQueries test

a9d095d

Hacked it into a bounds check.

🐛 Add missing bounds check and mark a data race

27514b6

🏷️ [#565] Add type annotation

1d8197a

✅ [#565] Test export action and import tool in admin

fff6882

CharString force-pushed the 565-exportimport-object-types-with-uuid-retention branch from dc54480 to a3d29d5 Compare March 17, 2026 13:31

✅ [#565] Fix coverage

ae2f045

Queryset is never empty; django admin already checks this when performing an action.

CharString force-pushed the 565-exportimport-object-types-with-uuid-retention branch from a3d29d5 to ae2f045 Compare March 17, 2026 14:21

CharString requested a review from stevenbal March 17, 2026 14:30

CharString commented Mar 17, 2026

View reviewed changes

CharString requested a review from Floris272 March 18, 2026 09:34

stevenbal requested changes Mar 19, 2026

View reviewed changes

CharString and others added 4 commits March 20, 2026 15:11

🎨 [#565] Change __contains__ for __eq__

aa2fcfa

Co-authored-by: Steven Bal <steven@maykinmedia.nl>

💄 [#565] Fix alignment of errors

0820c57

Still not super pretty, but .aligned has a lot of left margin, which looks very off.

💬 [#565] Fix congruency between label and help_text

c7da3e8

📝 [#565] Document export import of object types

ec33c14

CharString requested a review from stevenbal March 20, 2026 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export-import object types with UUID retention#745

Export-import object types with UUID retention#745
CharString wants to merge 13 commits intomasterfrom
565-exportimport-object-types-with-uuid-retention

CharString commented Mar 16, 2026 •

edited

Loading

Uh oh!

codecov-commenter commented Mar 16, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CharString Mar 17, 2026

Uh oh!

stevenbal Mar 19, 2026

Uh oh!

stevenbal left a comment

Uh oh!

stevenbal Mar 19, 2026

Uh oh!

stevenbal Mar 19, 2026

Uh oh!

Uh oh!

stevenbal Mar 19, 2026

Uh oh!

CharString commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	help_text=_("Import keeping the same UUID as in the export."),
	help_text=_("Import keeping the same UUIDs as in the export."),

	field for field in _ObjectTypeSerializer.Meta.fields if field not in ["url"]
	field for field in _ObjectTypeSerializer.Meta.fields if field != "url"

Conversation

CharString commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bencher Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CharString Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

stevenbal Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stevenbal left a comment

Choose a reason for hiding this comment

Uh oh!

stevenbal Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

stevenbal Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stevenbal Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

CharString commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CharString commented Mar 16, 2026 •

edited

Loading

codecov-commenter commented Mar 16, 2026 •

edited

Loading

github-actions bot commented Mar 16, 2026 •

edited

Loading