📝 [#564] refactor docs for objecttype migrations#737
📝 [#564] refactor docs for objecttype migrations#737
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 85.58% 85.86% +0.28%
==========================================
Files 144 144
Lines 3003 3021 +18
Branches 236 239 +3
==========================================
+ Hits 2570 2594 +24
+ Misses 381 376 -5
+ Partials 52 51 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c088c2f to
259cf11
Compare
docs/api/performance.rst
Outdated
| * A single user simulates requests for a duration of 5 minutes. | ||
|
|
||
| We run the tests after every major version of the Objects API. | ||
| We run the tests after every major version of the Open Objecten API. |
There was a problem hiding this comment.
I didn't know we had this performance test setup for Objects as well actually 😅
| We run the tests after every major version of the Open Objecten API. | |
| We run the tests after every major version of the Open Objecten. |
There was a problem hiding this comment.
It seems that the most recent test was done for 2.0.0-alpha, so it should probably be reset if we do it for 4.0.0 or be removed
There was a problem hiding this comment.
Hmm yeah, and this data also seems to be with only 500 objects and a single user doing requests (no concurrency).
I'd say we remove it and redo this properly later on with a better setup (more realistic data, higher concurrency, running on k8s)
8397f23 to
eb08b1f
Compare
eb08b1f to
3f1e534
Compare
docs/api/performance.rst
Outdated
| * A single user simulates requests for a duration of 5 minutes. | ||
|
|
||
| We run the tests after every major version of the Objects API. | ||
| We run the tests after every major version of the Open Objecten API. |
There was a problem hiding this comment.
Hmm yeah, and this data also seems to be with only 500 objects and a single user doing requests (no concurrency).
I'd say we remove it and redo this properly later on with a better setup (more realistic data, higher concurrency, running on k8s)
docs/introduction/versioning.rst
Outdated
| Objects API | ||
| =========== | ||
| Open Objecten API | ||
| ================= |
There was a problem hiding this comment.
On second thought, because this is about the version of the application, let's remove API from the heading as well
| ======= | ||
|
|
||
| Objects API produces application metrics (using Open Telemetry). | ||
| Open Objecten API produces application metrics (using Open Telemetry). |
There was a problem hiding this comment.
Could you also make sure the objects namespace is updated to the new namespace in the other examples? The same must be done for the metrics defined in code as well
| ------- | ||
|
|
||
| ``objects.object.creates`` | ||
| ``openobjecten.object.creates`` |
There was a problem hiding this comment.
i got otel_openobjecten_object_creates_total working from the docs example, it does take a few seconds before prometeus has it.

Fixes #564
Changes