client: add onchain reconciler to daemon

[snormore]

Summary of Changes

• Add an onchain reconciler to the daemon (doublezerod) that polls onchain state and automatically provisions/tears down tunnels, replacing the CLI-driven provisioning model
• Move status enrichment (device, metro, tenant, latency) from the CLI to the daemon's GET /v2/status endpoint, eliminating 4 redundant RPC calls per status invocation
• Add enable/disable CLI subcommands and daemon endpoints to control the reconciler, with persistent state across daemon restarts
• Refactor CLI connect to simply enable the reconciler and wait for the daemon to provision, rather than performing provisioning directly
• Replace file-based DB (doublezerod.json) with onchain-driven state; add automatic migration from legacy state files

Diff Breakdown

Category	Files	Lines (+/-)	Net
Core logic	16	+1879 / -1644	+235
Scaffolding	8	+152 / -28	+124
Tests	12	+2563 / -1011	+1552
Fixtures	14	+18 / -131	-113
Docs	4	+206 / -12	+194
Total	54	+4818 / -2826	+1992

~1900 lines of core logic changes (net +235 after removing legacy DB/provisioning code), supported by ~2500 lines of new tests and ~200 lines of docs/RFC.

Key files (click to expand)

• client/doublezerod/internal/manager/manager.go — onchain reconciler loop, tunnel provisioning from onchain state, enable/disable control, tunnel-src resolution
• client/doublezero/src/command/status.rs — simplified to read enriched fields from daemon v2/status instead of making SDK RPC calls
• client/doublezero/src/command/connect.rs — refactored to enable reconciler and poll for daemon-driven provisioning instead of provisioning directly
• client/doublezerod/internal/manager/http.go — v2/status enrichment logic, enable/disable endpoints, V2ServiceStatus with device/metro/tenant/latency
• client/doublezero/src/command/disconnect.rs — refactored to disable reconciler instead of sending remove request
• client/doublezero/src/servicecontroller.rs — added V2ServiceStatus struct, enable/disable endpoints, removed legacy provisioning
• client/doublezerod/internal/onchain/fetcher.go — CachingFetcher with 5s TTL and singleflight dedup for shared onchain data access
• client/doublezerod/internal/manager/state.go — persistent enabled/disabled state with migration from legacy doublezerod.json

Testing Verification

• 78/78 Rust CLI tests pass, including updated status/connect/disconnect/enable/disable tests
• Go daemon tests verified with GOOS=linux go vet (netlink syscalls require Linux for full test run)
• New daemon tests: reconciler lifecycle (provision, teardown, toggle), v2/status enrichment with onchain data, state persistence and migration, CachingFetcher TTL/singleflight, client IP discovery
• New E2E test TestE2E_IBRL_EnableDisable covering reconciler enable/disable flow
• E2E fixture templates updated for new v2/status response format
• Related: RFC-17: Client Onchain Reconciler

[Copilot]

Pull request overview

This PR moves tunnel provisioning from the doublezero CLI into an onchain-driven reconciler loop inside the doublezerod daemon, adds runtime enable/disable controls, and updates status/reporting + tests/fixtures accordingly.

Changes:

• Add an onchain reconciler (polling + provisioning/removal) to doublezerod, with persisted enable/disable state and new /enable, /disable, /v2/status endpoints.
• Update CLI flows (connect, status, plus new enable/disable) to interact with the reconciler rather than directly provisioning.
• Add caching onchain fetcher + adjust tests/e2e fixtures to account for reconciler state and updated output.

Reviewed changes

Copilot reviewed 66 out of 66 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
rfcs/rfc17-client-onchain-reconciler.md	RFC documenting reconciler design, state, endpoints, and rollout plan
CHANGELOG.md	Changelog entry describing reconciler + CLI enable/disable
e2e/user_ban_test.go	Treat missing tunnel interface as successful route withdrawal
e2e/multicast_test.go	Update status fixture usage to templated reconciler-aware output
e2e/internal/fixtures/diff.go	Make CLI-table diff parsing robust to non-table preamble lines
e2e/ibrl_with_allocated_ip_test.go	Update status fixture usage to templated reconciler-aware output
e2e/ibrl_test.go	Update status fixture usage to templated reconciler-aware output
e2e/ibrl_enable_disable_test.go	New E2E test for connect → disable → enable → restart persistence lifecycle
e2e/fixtures/multicast/doublezero_status_disconnected.txt	Remove old disconnected status fixture
e2e/fixtures/multicast/doublezero_status_disconnected.tmpl	New reconciler-aware disconnected status fixture template
e2e/fixtures/multicast/doublezero_status_connected_subscriber.tmpl	Add “Reconciler” column to connected multicast subscriber fixture
e2e/fixtures/multicast/doublezero_status_connected_publisher.tmpl	Add “Reconciler” column to connected multicast publisher fixture
e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_disconnected.txt	Remove old disconnected status fixture
e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_disconnected.tmpl	New reconciler-aware disconnected status fixture template
e2e/fixtures/ibrl_with_allocated_addr/doublezero_status_connected.tmpl	Add “Reconciler” column to connected allocated-IP fixture
e2e/fixtures/ibrl/doublezero_status_disconnected.txt	Remove old disconnected status fixture
e2e/fixtures/ibrl/doublezero_status_disconnected.tmpl	New reconciler-aware disconnected status fixture template
e2e/fixtures/ibrl/doublezero_status_connected.tmpl	Add “Reconciler” column to connected IBRL fixture
client/doublezerod/cmd/doublezerod/main.go	Add flags for client IP, reconciler poll interval, and state dir; pass into runtime
client/doublezerod/internal/runtime/run.go	Wire reconciler + state migration + caching fetcher; update routes handler wiring; latency now uses fetcher
client/doublezerod/internal/runtime/run_test.go	Update runtime tests to new Run() signature; remove statefile recovery assertions
client/doublezerod/internal/runtime/clientip.go	New client IP auto-discovery (explicit → interfaces → ifconfig.me)
client/doublezerod/internal/runtime/clientip_test.go	Unit tests for public IP classification and explicit IP behavior
client/doublezerod/internal/reconciler/reconciler.go	New reconciler loop + enable/disable endpoints + /v2/status
client/doublezerod/internal/reconciler/state.go	Persisted reconciler enable/disable state + migration from old doublezerod.json
client/doublezerod/internal/reconciler/state_test.go	Unit tests for state load/write + migration behavior
client/doublezerod/internal/reconciler/metrics.go	Prometheus metrics for reconciler polls/provisions/removals/matched users
client/doublezerod/internal/onchain/fetcher.go	New TTL-based caching fetcher shared by reconciler and latency subsystem
client/doublezerod/internal/onchain/fetcher_test.go	Unit tests for caching behavior (TTL, stale-on-error, concurrency)
client/doublezerod/internal/manager/manager.go	Remove DB/statefile dependency; add ResolveTunnelSrc + GetProvisionedServices
client/doublezerod/internal/manager/http_test.go	Update manager HTTP tests for removed DB + new GetProvisionedServices
client/doublezerod/internal/manager/db.go	Remove old on-disk state DB implementation
client/doublezerod/internal/manager/db_test.go	Remove tests for deleted DB/statefile system
client/doublezerod/internal/manager/fixtures/doublezerod.*.json	Remove fixtures used exclusively for deleted DB/statefile behavior
client/doublezerod/internal/services/base.go	Remove DBReaderWriter interface (services now keep ProvisionRequest in memory)
client/doublezerod/internal/services/services_test.go	Update service creation tests after DB removal
client/doublezerod/internal/services/ibrl.go	Store ProvisionRequest in memory; drop DB usage; expose ProvisionRequest()
client/doublezerod/internal/services/edgefiltering.go	Store ProvisionRequest in memory; drop DB usage; expose ProvisionRequest()
client/doublezerod/internal/services/multicast.go	Store ProvisionRequest in memory; drop DB usage; expose ProvisionRequest()
client/doublezerod/internal/latency/smartcontract.go	Remove old direct smartcontract fetcher module (replaced by fetcher integration)
client/doublezerod/internal/latency/manager.go	Support injected Fetcher; adjust SmartContractFunc signature and fetch path
client/doublezerod/internal/latency/manager_test.go	Update tests for new smartcontract func signature and removed program ID options
client/doublezerod/internal/api/routes.go	Replace DBReader with ServiceStateReader (provisioned services now in manager)
client/doublezerod/internal/api/routes_test.go	Update routes tests to use ServiceStateReader mock
client/doublezero/src/servicecontroller.rs	Add v2 status + enable/disable calls; remove CLI provisioning/remove/resolve-route APIs
client/doublezero/src/routes.rs	Remove resolve_route command surface; keep routes retrieval
client/doublezero/src/main.rs	Allow enable/disable commands without version warning gate
client/doublezero/src/cli/command.rs	Add doublezero enable / doublezero disable commands
client/doublezero/src/command/mod.rs	Register enable/disable subcommands
client/doublezero/src/command/enable.rs	New enable command implementation + unit tests
client/doublezero/src/command/disable.rs	New disable command implementation + unit tests
client/doublezero/src/command/status.rs	Use /v2/status; surface reconciler state in output/table; synthesize disconnected row when empty
client/doublezero/src/command/connect.rs	Switch connect flow to best-effort enable reconciler + poll daemon status for provisioning
client/doublezero/src/command/disconnect.rs	Stop calling daemon /remove; poll daemon for deprovision completion after onchain user deletion

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.