Skip to content

fix: respect sidebar decoration color in macos window (#587) #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rubenRoehner wants to merge 1 commit into
base: dev
Choose a base branch
from
+15 −12
Open

fix: respect sidebar decoration color in macos window (#587) #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [2.2.3]
### 🛠 Fixed 🛠
- Fixed sidebar background painting when wallpaper tinting is disabled: the macOS sidebar now stays transparent unless a decoration color is provided (previously showed a black strip). Addresses #587.

## [2.2.2]
### 🛠 Fixed 🛠
- Fixed setState called after dispose issue in MacosPulldownButton.
Expand Down
21 changes: 10 additions & 11 deletions lib/src/layout/window.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,18 +195,15 @@ class _MacosWindowState extends State<MacosWindow> {
}
final MacosThemeData theme = MacosTheme.of(context);
late Color backgroundColor = widget.backgroundColor ?? theme.canvasColor;
late Color sidebarBackgroundColor;
late Color? sidebarBackgroundColor;
late Color endSidebarBackgroundColor;
Color dividerColor = theme.dividerColor;

final isMac = !kIsWeb && defaultTargetPlatform == TargetPlatform.macOS;

// Respect the sidebar color override from parent if one is given
if (sidebar?.decoration?.color != null) {
sidebarBackgroundColor = sidebar!.decoration!.color!;
} else {
sidebarBackgroundColor = MacosColors.transparent;
}
sidebarBackgroundColor =
sidebar?.decoration?.color ?? (kIsWeb ? theme.canvasColor : null);
Comment on lines 204 to +206
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces new sidebar background behavior across platforms (transparent on macOS unless Sidebar.decoration.color is set; theme.canvasColor on web). Since test/layout/window_test.dart already covers MacosWindow/Sidebar, it would be good to add a widget test asserting the expected background paint behavior for (1) no decoration color vs (2) a provided decoration color, to prevent regressions like the black strip issue.

Copilot uses AI. Check for mistakes.

// Set the application window's brightness on macOS
MacOSBrightnessOverrideHandler.ensureMatchingBrightness(theme.brightness);
Expand Down Expand Up @@ -273,7 +270,7 @@ class _MacosWindowState extends State<MacosWindow> {
).normalize(),
child: kIsWeb
? ColoredBox(
color: theme.canvasColor,
color: sidebarBackgroundColor ?? theme.canvasColor,
child: Column(
children: [
// If an app is running on macOS, apply
Expand Down Expand Up @@ -326,10 +323,12 @@ class _MacosWindowState extends State<MacosWindow> {
: TransparentMacOSSidebar(
state: sidebarState,
child: DecoratedBox(
decoration: const BoxDecoration(
color: Color.fromRGBO(0, 0, 0, 1.0),
backgroundBlendMode: BlendMode.clear,
),
decoration:
(sidebar.decoration ?? const BoxDecoration())
.copyWith(
// Only paint if the caller set a color; null preserves native transparency.
color: sidebarBackgroundColor,
),
Comment on lines +327 to +331
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the non-web branch, AnimatedContainer already paints sidebarBackgroundColor via its color:. The new DecoratedBox also applies sidebarBackgroundColor as the BoxDecoration.color, which will effectively paint the color twice when the caller provides a semi-transparent Sidebar.decoration.color (making it appear darker than requested). Consider having only a single widget paint the background color (e.g., move the sidebar.decoration/color onto AnimatedContainer.decoration and drop the inner color paint) so opacity is applied exactly once.

Suggested change
(sidebar.decoration ?? const BoxDecoration())
.copyWith(
// Only paint if the caller set a color; null preserves native transparency.
color: sidebarBackgroundColor,
),
sidebar.decoration ?? const BoxDecoration(),

Copilot uses AI. Check for mistakes.
child: Column(
children: [
// If an app is running on macOS, apply
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: macos_ui
description: Flutter widgets and themes implementing the current macOS design language.
version: 2.2.2
version: 2.2.3
homepage: "https://macosui.dev"
repository: "https://github.com/GroovinChip/macos_ui"

Expand Down
Loading